Conversation
|
Note the comment: "Make sure to update Directory.Build.targets too!" |
Where is this comment? This file is currently empty |
|
The comment is line 8 of the file you modified--the line before your modification--and no, Directory.Build.targets is not currently empty, it's a duplicate of Directory.Build.Props |
|
Directory.Build.targets is empty at main branch: https://github.com/mono/taglib-sharp/blob/main/Directory.Build.targets |
|
Ah, so it is ... I must have been looking at some other version. But then, the comment should be removed. |
| <ExeTargetFrameworks>net6.0;net472</ExeTargetFrameworks> | ||
| <LibTargetFrameworks>net6.0;netstandard2.0</LibTargetFrameworks> | ||
| <ExeTargetFrameworks>net7.0;net472</ExeTargetFrameworks> | ||
| <LibTargetFrameworks>net7.0;netstandard2.0</LibTargetFrameworks> |
There was a problem hiding this comment.
@xaviergxf Thanks for the PR. Could I have you leave the net6.0 and add net8.0 instead. net8.0 is an LTS version and was just barely released.
There was a problem hiding this comment.
I have updated it on my side but there are now problems regarding deprecation of Formatter-based serialization. I don't understand why this is used...
There was a problem hiding this comment.
oh fun :) ok, I'll try and take a peek at this too.
|
I just merged net8.0 and net9.0 support |
4 participants
Hi Everyone,
Just migrating the project to .net 7