Support arm64 native assets for Tizen #2324
Draft
+25
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rookiejava
force-pushed
the
update-tizen-native-asset
branch
from
9fae8f4
to
232f526
Compare
|
I think arm64 arch build should be supported on |
rookiejava
force-pushed
the
update-tizen-native-asset
branch
from
232f526
to
82869ff
Compare
mattleibow
approved these changes
Mar 15, 2023
|
Let me have a look at CI and see what is happening... |
mattleibow
reviewed
Jun 12, 2023
| <None Include="..\..\output\native\tizen\armel\libHarfBuzzSharp.*" Link="nuget\runtimes\tizen-armel\%(Filename)%(Extension)" /> | ||
| <None Include="..\..\output\native\tizen\arm64\libHarfBuzzSharp.*" Link="nuget\runtimes\tizen-arm64\%(Filename)%(Extension)" /> | ||
| <None Include="..\..\output\native\tizen\i386\libHarfBuzzSharp.*" Link="nuget\runtimes\tizen-x86\%(Filename)%(Extension)" /> | ||
| <None Include="..\..\output\native\tizen\i386\libHarfBuzzSharp.*" Link="nuget\runtimes\linux-x86\%(Filename)%(Extension)" /> |
There was a problem hiding this comment.
Do we still need the linux-x86 runtime? I am not sure we can do this as it will replace the linux binary - and will also cause the tizen binary to run on a linux (desktop) machine.
What we can do is actually just keep the tizen-x86 version, and pack it twice in the tizen nuget.
| @@ -39,11 +41,14 @@ Please visit https://go.microsoft.com/fwlink/?linkid=868517 to view the release | |||
| <file src="build/tizen40/HarfBuzzSharp.targets" target="buildTransitive/tizen40/HarfBuzzSharp.NativeAssets.Tizen.targets" /> | |||
|
|
|||
| <!-- libHarfBuzzSharp.dll and other native files --> | |||
| <file src="build/tizen40/arm/libHarfBuzzSharp.so" /> | |||
| <file src="build/tizen40/x86/libHarfBuzzSharp.so" /> | |||
| <file src="runtimes/linux-x86/native/libHarfBuzzSharp.so" /> | |||
There was a problem hiding this comment.
Suggested change
| <file src="runtimes/linux-x86/native/libHarfBuzzSharp.so" /> | |
| <file src="runtimes/tizen-x86/native/libHarfBuzzSharp.so" target="runtimes/linux-x86/native/libHarfBuzzSharp.so" /> |
| <None Include="..\..\output\native\tizen\armel\libSkiaSharp.*" Link="nuget\runtimes\tizen-armel\libSkiaSharp.so" /> | ||
| <None Include="..\..\output\native\tizen\arm64\libSkiaSharp.*" Link="nuget\runtimes\tizen-arm64\libSkiaSharp.so" /> | ||
| <None Include="..\..\output\native\tizen\i386\libSkiaSharp.*" Link="nuget\runtimes\tizen-x86\libSkiaSharp.so" /> | ||
| <None Include="..\..\output\native\tizen\i386\libSkiaSharp.*" Link="nuget\runtimes\linux-x86\libSkiaSharp.so" /> |
There was a problem hiding this comment.
Same as above, don't copy here, just pack twice.
| @@ -40,11 +42,14 @@ Please visit https://go.microsoft.com/fwlink/?linkid=868517 to view the release | |||
| <file src="build/tizen40/SkiaSharp.targets" target="buildTransitive/tizen40/SkiaSharp.NativeAssets.Tizen.targets" /> | |||
|
|
|||
| <!-- libSkiaSharp.dll and other native files --> | |||
| <file src="build/tizen40/arm/libSkiaSharp.so" /> | |||
| <file src="build/tizen40/x86/libSkiaSharp.so" /> | |||
| <file src="runtimes/linux-x86/native/libSkiaSharp.so" /> | |||
There was a problem hiding this comment.
Suggested change
| <file src="runtimes/linux-x86/native/libSkiaSharp.so" /> | |
| <file src="runtimes/tizen-x86/native/libSkiaSharp.so" target="runtimes/linux-x86/native/libSkiaSharp.so" /> |
mattleibow
changed the title
|
Hopefully my review makes sense... I think I forgot the picture I have in my head is not really visible outside my mind... |
|
I tried using the latest Tizen Studio on the new main, and it appears the be missing headers. I forget now, but it was like missing math headers or something. I was able to see the arm/x86 had more headers than the arm64/x64. |
mattleibow
added
area/libSkiaSharp.native
area/libHarfBuzzSharp.native
os/Tizen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR is for arm64 support in
SkiaSharp.NativeAssets.TizenandHarfBuzzSahrp.NativeAssets.Tizen.Bugs Fixed
None.
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist