Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nsType optional in ChangeStreamDocument #1759

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Feb 24, 2025

Specifications typically use Optional<...> instead of | null to indicate that a field is only present in some circumstances because drivers represent conditionally present values differently. While some drivers might use null to indicate that a value isn't present, other drivers (like Node) omit keys entirely.

The changes in this PR make nsInfo consistent with other optional fields (ex: to or operationDescription).
Please complete the following before merging:

  • Update changelog.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@baileympearson baileympearson requested a review from a team as a code owner February 24, 2025 18:18
@baileympearson baileympearson requested review from abr-egn and removed request for a team February 24, 2025 18:18
@baileympearson baileympearson merged commit 366afd6 into master Feb 24, 2025
4 checks passed
@baileympearson baileympearson deleted the baileympearson-patch-1 branch February 24, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants