DRIVERS-2781 increase wait time.
#1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accounts for coarse time resolution on Windows. Waiting for 2ms may not expire the key in libmongocrypt on Windows due to CDRIVER-4526.
kevinAlbs
requested review from
katcharov
and removed request for
a team and
katcharov
adriandole
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1730
waittime inkeyCache.jsontests to fix failures on Windows.keyExpirationMS=0means "never expire".See mongodb/mongo-c-driver#1804 for motivation.
Please complete the following before merging:
[ ] Update changelog.[ ] Test these changes against all server versions and topologies (including standalone, replica set, shardedVerified by this patch build. But C does not test serverless.clusters, and
serverless).