Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-3061: Skip $out test on serverless #1739

Merged
merged 1 commit into from
Dec 3, 2024
Merged

DRIVERS-3061: Skip $out test on serverless #1739

merged 1 commit into from
Dec 3, 2024

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Dec 3, 2024 •
edited
Loading

https://jira.mongodb.org/browse/DRIVERS-3061

Please complete the following before merging:

  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

POC: mongodb/mongo-php-library#1547

@jmikola jmikola requested a review from a team as a code owner December 3, 2024 14:22
@jmikola jmikola requested review from aditi-khare-mongoDB and removed request for a team December 3, 2024 14:22
kevinAlbs
kevinAlbs approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. With suggested comment applied, test passes in the Rust driver serverless task (Other failing non-retryable writes tests were skipped and is tracked in RUST-2105).

@jmikola jmikola mentioned this pull request Dec 3, 2024
Merged
@jmikola jmikola merged commit ce9b56b into mongodb:master Dec 3, 2024
5 checks passed
@jmikola jmikola deleted the drivers-3061 branch December 3, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus left review comments

@kevinAlbs kevinAlbs kevinAlbs approved these changes

@aditi-khare-mongoDB aditi-khare-mongoDB Awaiting requested review from aditi-khare-mongoDB aditi-khare-mongoDB is a code owner automatically assigned from mongodb/dbx-spec-owners-retryability

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmikola @alcaeus @kevinAlbs