Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2798 Drivers do not gossip $clusterTime on SDAM commands #1735

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

ShaneHarvey
Copy link
Member

@ShaneHarvey ShaneHarvey commented Nov 22, 2024

Please complete the following before merging:

  • Update changelog.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@ShaneHarvey ShaneHarvey requested a review from a team as a code owner November 22, 2024 00:07
@ShaneHarvey ShaneHarvey requested review from qingyang-hu, jyemin and a team and removed request for a team November 22, 2024 00:07
Copy link
Member

@sanych-sun sanych-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShaneHarvey ShaneHarvey requested a review from jyemin December 2, 2024 19:23
Copy link
Contributor

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ShaneHarvey ShaneHarvey requested a review from jyemin February 25, 2025 00:05
@ShaneHarvey
Copy link
Member Author

Apologies for the delay here. I fixed some minor issues with the prose test description that I discovered while implementing this in Python here: mongodb/mongo-python-driver#1925

@jyemin please take another look.

@ShaneHarvey ShaneHarvey merged commit b76cbf9 into mongodb:master Feb 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants