Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move handshake prose tests from spec into prose test file #1714

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Move handshake prose tests from spec into prose test file #1714

merged 2 commits into from
Nov 6, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Nov 1, 2024 •
edited by dariakp
Loading

The handshake spec had prose tests inside the spec instead of inside the prose test file. This PR moves the handshake tests into the prose test file.

Please complete the following before merging:

  • Update changelog.
  • [N/A] Test changes in at least one language driver.
  • [N/A] Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@baileympearson baileympearson requested a review from a team as a code owner November 1, 2024 20:17
@baileympearson baileympearson requested review from dariakp and removed request for a team November 1, 2024 20:17
dariakp
dariakp requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still want to update the change log in the files

@dariakp dariakp merged commit 3a4c773 into master Nov 6, 2024
5 checks passed
@dariakp dariakp deleted the no-story-consolidate-handshake-prose-tests branch November 6, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baileympearson @dariakp