Skip to content

DRIVERS-2953 getMore should not have maxTimeMS for non-tailable cursor #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2024
Merged

DRIVERS-2953 getMore should not have maxTimeMS for non-tailable cursor #1710

merged 1 commit into from
Nov 1, 2024

Conversation

prestonvasquez
Copy link
Member

DRIVERS-2953

The only time a "getMore" can include "maxTimeMS" is for a tailable awaitData cursor. The test bug is masked because the test case expects a timeout on "getMore", preventing the driver from receiving the server error.

Please complete the following before merging:

  • Update changelog.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@prestonvasquez prestonvasquez requested a review from a team as a code owner October 31, 2024 20:29
@prestonvasquez prestonvasquez merged commit 38cbbce into mongodb:master Nov 1, 2024
5 checks passed
@prestonvasquez prestonvasquez deleted the DRIVERS-2953 branch November 1, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestonvasquez @ShaneHarvey