Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ak8so role #647

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix ak8so role #647

merged 1 commit into from
Feb 12, 2025

Conversation

rayangler
Copy link
Collaborator

@rayangler rayangler commented Feb 12, 2025 •
edited
Loading

Notes

  • This was incoming Slack request to fix the role destination.
  • The request was to make sure the role link pointed to the correct path prefix for the site. This docs site is currently versioned, but Slack thread confirms that it's okay to not have the version included in the role destination.

README updates

    • This PR introduces changes that should be reflected in the README.md and/or HACKING.md, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README.md and/or HACKING.md

JuliaMongo
JuliaMongo approved these changes Feb 12, 2025
View reviewed changes
Copy link

@JuliaMongo JuliaMongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@mmeigs mmeigs self-requested a review February 12, 2025 20:34
@rayangler rayangler merged commit 84ccd7e into main Feb 12, 2025
5 checks passed
@rayangler rayangler deleted the ak8so-fix branch February 12, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmeigs mmeigs mmeigs approved these changes

@JuliaMongo JuliaMongo JuliaMongo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rayangler @mmeigs @JuliaMongo