DOP-4207: pre determine image dimensions in parser #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i80and
suggested changes
Jan 4, 2024
i80and
reviewed
Jan 4, 2024
i80and
reviewed
Jan 4, 2024
i80and
approved these changes
Jan 9, 2024
seungpark
commented
Jan 10, 2024
| @@ -159,6 +159,10 @@ def __call__( | |||
| try: | |||
| checksum = self.asset.get_checksum() | |||
| options["checksum"] = checksum | |||
| dimensions = self.asset.dimensions | |||
| if dimensions is not None: | |||
| options["width"] = str(dimensions[0]) | |||
There was a problem hiding this comment.
@i80and seems like this will overwrite some input user data (ie. width option). validating this is None before overwriting in a follow up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Add width and height properties to images and figures such that the AST contains these dimensions in order for snooty to lazy load images in the same dimension.
I added this package as a lightweight image size getter, but open to suggestion such as PIL.
Package has been installed via CLI command
poetry add [email protected]which updated pyproject.toml and poetry.lock subsequently.Example of staged changes with frontend branch
Note:
diagnosticsproperty to static_asset so that any errors while getting image dimensions will appended to the parser's diagnostics. ex:Question:
widthandscaleoptions of image directive? seems like from this example of image directive usage, it is a existing bug to not respect this width (HTML output)