CLOUDP-359062 - add ownerrefs and only deleteAll in multicluster #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCK 1.6.1 Release NotesBug Fixes
|
Julien-Ben
approved these changes
Dec 2, 2025
vinilage
approved these changes
Dec 4, 2025
Comment on lines
+1
to
+7
| --- | ||
| kind: fix | ||
| date: 2025-12-02 | ||
| --- | ||
|
|
||
| * **MongoDB** Adding missing ownerrefs to ensure proper resource deletion by kubernetes. | ||
| * **Single Cluster** Deleting resources created by CRD now only happens on multi-cluster deployments. Single Cluster will solely rely on ownerrefs. |
lsierant
reviewed
Dec 4, 2025
| clusterClient := item.Client | ||
| clusterName := item.Name | ||
| if err := r.commonController.deleteClusterResources(ctx, clusterClient, clusterName, sc, log); err != nil { | ||
| errs = multierror.Append(errs, xerrors.Errorf("failed deleting dependant resources in cluster %s: %w", clusterName, err)) |
Contributor
There was a problem hiding this comment.
in om's controller we're only logging the error in this case
here though failing to delete will result in errors returned - would that impact anything?
lsierant
reviewed
Dec 4, 2025
| namespace string | ||
| resourceName string | ||
| ownerLabels map[string]string | ||
| ownerReferences []metav1.OwnerReference |
Contributor
There was a problem hiding this comment.
how the stored owner refs are actually consumed by the controller's impl?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes: #589
This pull request introduces important improvements to how Kubernetes resources are managed and cleaned up for MongoDB and Ops Manager deployments, especially in multi-cluster versus single-cluster scenarios. The main focus is on correctly setting owner references for resources to enable automatic garbage collection by Kubernetes, and ensuring explicit resource deletion only occurs when necessary (i.e., in multi-cluster setups where owner references cannot span clusters).
Owner Reference Management & Resource Cleanup
ownerReferences) to all relevant ConfigMaps and resources for MongoDB and Ops Manager, ensuring proper automatic cleanup by Kubernetes in single-cluster deployments.appdbreplicaset_controller.go,mongodbopsmanager_controller.go,mongodbshardedcluster_controller.go,state_store.go) to consistently pass and setownerReferences.Multi-Cluster vs Single-Cluster Resource Deletion Logic
Proof of Work
Checklist
skip-changeloglabel if not needed