Skip to content

CLOUDP-331496: Split operator roles into smaller templates: split base role #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

m1kola
Copy link
Contributor

@m1kola m1kola commented Jul 14, 2025

Summary

In #258 I split existing roles into separate files: base RBAC, telemetry, webhook and clustermongodbroles related RBAC.

In this iteration we split basic role further. We separate PVC resize permissions into a separate role.

Proof of Work

CI must be green.

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@m1kola m1kola changed the title Helm smaller templates split base Split operator roles into smaller templates: split base role Jul 14, 2025
@m1kola m1kola changed the title Split operator roles into smaller templates: split base role CLOUDP-331496: Split operator roles into smaller templates: split base role Jul 15, 2025
@m1kola m1kola force-pushed the helm_smaller_templates_split_base branch 2 times, most recently from 5d3047d to 417a852 Compare July 15, 2025 09:40
@m1kola m1kola force-pushed the helm_smaller_templates_split_base branch from 417a852 to 9337230 Compare July 15, 2025 10:38
@m1kola m1kola marked this pull request as ready for review July 15, 2025 10:40
@m1kola m1kola requested a review from a team as a code owner July 15, 2025 10:40
Copy link
Contributor

@lsierant lsierant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
While it's functionally equivalent it is a somewhat user facing change. Consider putting a RN entry just for awareness.

Copy link
Collaborator

@MaciejKaras MaciejKaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Still this PR is not only about moving the yamls around but it also introduces new template. Some of the template expressions are tested with helm (public dir), but I miss the testing facility for our helm charts to support different input values.

@m1kola
Copy link
Contributor Author

m1kola commented Jul 15, 2025

@MaciejKaras sorry if my description gave the wrong impression. #258 was moving things into new templates. This PR is slightly move invasive since it introduces a new role & role binding.

Regarding testing: Nam shared https://github.com/helm-unittest/helm-unittest with me recently, but I haven't tried it. We might want to look into whether it is worth adopting it.

@lsierant I'm not sure if this change is worthy of a release note, but we can add it just in case. I think I'll do it in a separate PR so I don't have to wait for the CI again here.

m1kola added a commit to m1kola/mongodb-kubernetes that referenced this pull request Jul 15, 2025
@m1kola
Copy link
Contributor Author

m1kola commented Jul 15, 2025

Merging. Release notes will be added in #266.

@m1kola m1kola merged commit 536c2dc into mongodb:master Jul 15, 2025
35 checks passed
@m1kola m1kola deleted the helm_smaller_templates_split_base branch July 15, 2025 14:47
m1kola added a commit that referenced this pull request Jul 15, 2025
Release notes for:
* #261
* #260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants