-
Notifications
You must be signed in to change notification settings - Fork 11
CLOUDP-331496: Split operator roles into smaller templates: split base role #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-331496: Split operator roles into smaller templates: split base role #260
Conversation
5d3047d
to
417a852
Compare
417a852
to
9337230
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
While it's functionally equivalent it is a somewhat user facing change. Consider putting a RN entry just for awareness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Still this PR is not only about moving the yamls around but it also introduces new template. Some of the template expressions are tested with helm (public dir), but I miss the testing facility for our helm charts to support different input values.
@MaciejKaras sorry if my description gave the wrong impression. #258 was moving things into new templates. This PR is slightly move invasive since it introduces a new role & role binding. Regarding testing: Nam shared https://github.com/helm-unittest/helm-unittest with me recently, but I haven't tried it. We might want to look into whether it is worth adopting it. @lsierant I'm not sure if this change is worthy of a release note, but we can add it just in case. I think I'll do it in a separate PR so I don't have to wait for the CI again here. |
Release notes for: * mongodb#261 * mongodb#260
Merging. Release notes will be added in #266. |
Summary
In #258 I split existing roles into separate files: base RBAC, telemetry, webhook and
clustermongodbroles
related RBAC.In this iteration we split basic role further. We separate PVC resize permissions into a separate role.
Proof of Work
CI must be green.
Checklist
Reminder (Please remove this when merging)