Fix use of TOOLS_TESTING_MONGOD with development server builds #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s helpful to be able to run tests locally using the same clusters that other provisioning tools use.
configureClient(), however, only honors the hosts from the connection string, not the authentication.Additionally, the logic to extract a MongoDB version from
buildInfo’sversionArraydid not account for the mismatch between that field andversionin development builds. Also, certain tests that require an unauthenticated connection did not skip appropriately under authentication.This changeset fixes both of those oversights so that it’s now possible to run the integrations tests thus:
… even when the connection string is authenticated and/or a development server.