Fix: MongoClientSettings.applyConnectionString retryReads bug

Ensure that retryReads is copied. JAVA-5048
mongodb · Jul 11, 2023 · 2bad9c5 · 2bad9c5
1 parent 1630676
commit 2bad9c5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/driver-core/src/main/com/mongodb/MongoClientSettings.java b/driver-core/src/main/com/mongodb/MongoClientSettings.java
@@ -299,6 +299,10 @@ public Builder applyConnectionString(final ConnectionString connectionString) {
             if (retryWritesValue != null) {
                 retryWrites = retryWritesValue;
             }
+            Boolean retryReadsValue = connectionString.getRetryReads();
+            if (retryReadsValue != null) {
+                retryReads = retryReadsValue;
+            }
             if (connectionString.getUuidRepresentation() != null) {
                 uuidRepresentation = connectionString.getUuidRepresentation();
             }

diff --git a/driver-core/src/test/unit/com/mongodb/MongoClientSettingsSpecification.groovy b/driver-core/src/test/unit/com/mongodb/MongoClientSettingsSpecification.groovy
@@ -194,7 +194,7 @@ class MongoClientSettingsSpecification extends Specification {
                 .readPreference(ReadPreference.secondary())
                 .writeConcern(WriteConcern.JOURNALED)
                 .retryWrites(true)
-                .retryReads(false)
+                .retryReads(true)
                 .readConcern(ReadConcern.LOCAL)
                 .applicationName('app1')
                 .addCommandListener(commandListener)