-
Notifications
You must be signed in to change notification settings - Fork 917
GODRIVER-3473 Short-cicruit cursor.next() on invalid timeouts #2135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change Report./v2/x/mongo/drivercompatible changes(*BatchCursor).MaxAwaitTime: added |
9bb1fb5
to
5006d50
Compare
matthewdale
reviewed
Jul 31, 2025
dc35fae
to
e54cc2f
Compare
dc35fae
to
eb14ddf
Compare
eb14ddf
to
57c1140
Compare
matthewdale
approved these changes
Aug 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3473
Summary
Short-circuit calls to
cursor.Next()
where maxAwaitTimeMS >= operation timeout, which would result in socket timeouts.Background & Motivation
The specifications assume that drivers iteratively apply the timeout provided at the constructor level (e.g.,
(*collection).Find
) for tailable awaitData cursors:The Go Driver might decide to support the above behavior with DRIVERS-2722. The principal concern is that it would be unexpected for users to apply an operation-level timeout via contexts to a constructor and then have that timeout later be applied while working with a resulting cursor. Instead, it is more idiomatic to apply the timeout to the context passed to
Next
orTryNext
.