Fix panic in TestCollection/insert_many when nothing is inserted. #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdale
force-pushed
the
fix-test-coll-panic
branch
from
c1d1208 to
9c1a3fe
Compare
API Change ReportNo changes found! |
matthewdale
requested review from
qingyang-hu
and removed request for
prestonvasquez
qingyang-hu
reviewed
Mar 24, 2025
| we, ok := err.(mongo.BulkWriteException) | ||
| assert.True(mt, ok, "expected error type %T, got %T", mongo.BulkWriteException{}, err) | ||
| numErrors := len(we.WriteErrors) | ||
| assert.Equal(mt, tc.numErrors, numErrors, "expected %v write errors, got %v", tc.numErrors, numErrors) | ||
| gotCode := we.WriteErrors[0].Code | ||
| assert.Equal(mt, errorDuplicateKey, gotCode, "expected error code %v, got %v", errorDuplicateKey, gotCode) | ||
|
|
||
| if len(res.InsertedIDs) == 0 { |
There was a problem hiding this comment.
Can we use a require.Greater()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Only assert on the contents of
InsertedIDsin theTestCollection/insert_many/return_only_inserted_idstest if the length is greater than 0.Background & Motivation
The test
TestCollection/insert_many/return_only_inserted_idssometimes panics when theInsertManyfails. One of the assertions accesses the first ID in theInsertedIDslist, which panics if the list is empty. The panic hides the root cause error because the error assertions are later in the test code.