Skip to content

Conversation

@eramongodb
Copy link
Contributor

Related to CXX-3235 and CXX-3236. Followup to #1462, prompted by review of #1482.

Per comment:

Re-reading #1462, should v1::encrypt be renamed to v1::encrypt_options?

and comment:

#1462 notes the _options suffix is "Limited to options for commands with the same name". However, it might be a helpful cue for some types. E.g. v1::data_key might initially be read as "represents a data key" rather than "options to create a data key".

The CSE spec uses the names DataKeyOpts, EncryptOpts, RangeOpts, and AutoEncryptionOpts. Consider using the _options suffix on those types for consistency with the spec.

This PR applies the *_options suffix to the suggested class types.

Warning

The git file rename detection algorithm seems to be confused and is mixing up files with one another when describing changes in this PR.

For reference, remaining "options" (or options-like) classes which do not have the *_options suffix after the changes in this PR include:

  • apm
  • hint
  • read_concern
  • read_preference
  • server_api
  • tls
  • transaction
  • write_concern

@eramongodb eramongodb requested a review from kevinAlbs October 28, 2025 16:44
@eramongodb eramongodb self-assigned this Oct 28, 2025
@eramongodb eramongodb requested a review from a team as a code owner October 28, 2025 16:44
@eramongodb eramongodb merged commit 9154447 into mongodb:master Oct 28, 2025
18 of 19 checks passed
@eramongodb eramongodb deleted the cxx-abi-v1-options branch October 28, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants