CSHARP-5392: Add integration tests for transactions write concern behavior #1733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisDog
requested changes
Jul 18, 2025
| namespace MongoDB.Driver.Tests.Specifications.transactions | ||
| { | ||
| [Trait("Category", "Integration")] | ||
| public class TransactionsProseTests |
There was a problem hiding this comment.
Let's make it inherit from LoggableTestClass, so we get logs on failure.
| [Trait("Category", "Integration")] | ||
| public class TransactionsProseTests | ||
| { | ||
| private string _collectionName = "txn-test-col"; |
| // https://github.com/mongodb/specifications/blob/fc7996db26d0ea92091a5034c6acb287ef7282fe/source/transactions/tests/README.md#10-write-concern-not-inherited-from-collection-object-inside-transaction | ||
| [Theory] | ||
| [ParameterAttributeData] | ||
| public async void Ensure_write_concern_is_not_inherited_from_collection_object_inside_transaction([Values(false, true)] bool async) |
| } | ||
| } | ||
|
|
||
| exception.Should().BeNull(); |
There was a problem hiding this comment.
There is no need to use Record in order to validate the absence of exception. The test will just fail on exception.
It's usually used to validate that exception was thrown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.