Skip to content

CSHARP-5587: FindOneAndUpdate should insert correct discriminator value on upsert #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

rstam
Copy link
Contributor

@rstam rstam commented May 15, 2025

No description provided.

@rstam rstam requested review from sanych-sun and adelinowona May 15, 2025 17:12
@rstam rstam requested a review from a team as a code owner May 15, 2025 17:12
@rstam rstam added the bug label May 15, 2025
Copy link
Contributor

@adelinowona adelinowona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a comment though

Comment on lines 114 to 116
// [
// new Animal { }
// ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this is a residue? maybe remove?

Copy link
Member

@sanych-sun sanych-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rstam rstam merged commit cacbcf8 into mongodb:main Jun 10, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants