CSHARP-5204: Test Heartbeats don't gossip cluster time #1665
+50
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adelinowona
requested review from
JamesKovacs and
BorisDog
and removed request for
a team and
JamesKovacs
BorisDog
requested changes
Apr 9, 2025
tests/MongoDB.Driver.Tests/Specifications/sessions/SessionsProseTests.cs
Outdated
Show resolved
Hide resolved
tests/MongoDB.Driver.Tests/Specifications/sessions/SessionsProseTests.cs
Show resolved
Hide resolved
sanych-sun
reviewed
Apr 10, 2025
tests/MongoDB.Driver.Tests/Specifications/sessions/SessionsProseTests.cs
Show resolved
Hide resolved
sanych-sun
requested changes
Apr 10, 2025
BorisDog
approved these changes
Apr 11, 2025
sanych-sun
requested changes
Apr 16, 2025
| { | ||
| var capturedEvents = events.ToArray(); | ||
| return capturedEvents.Count(e => e is ServerHeartbeatSucceededEvent) > 1 && | ||
| capturedEvents |
There was a problem hiding this comment.
I think this code could be simplified a little by using the following approach:
capturedEvents
.SkipUntil(e => <first event condition>)
.Any(e => <second event condition>)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we were already not gossiping cluster times in our monitoring connections. Our monitors send hello requests which use a
NoCoreSessioninstance when the wire protocol command is created for a hello request. ANoCoreSessioninstance has a nullClusterTimewhich cannot be changed and callingsession.AdvanceClusterTimeis also a no-op for aNoCoreSession. So this PR just adds the new prose test described in the Drivers spec update: mongodb/specifications@b76cbf9