Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSHARP-5529: Optimize grouping.First().X to not retrieve the entire $$ROOT #1653

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CSHARP-5529: Optimize grouping.First().X to not retrieve the entire $$ROOT #1653

wants to merge 2 commits into from

Conversation

rstam
Copy link
Contributor

@rstam rstam commented Mar 28, 2025

No description provided.

@rstam rstam requested review from sanych-sun and adelinowona March 28, 2025 18:22
@rstam rstam requested a review from a team as a code owner March 28, 2025 18:22
adelinowona
adelinowona requested changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@adelinowona adelinowona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but you should update the LINQ2 tests as well since the optimization changes the output. Evergreen is failing because of that.

@rstam
Copy link
Contributor Author

rstam commented Mar 31, 2025

Looks good but you should update the LINQ2 tests as well since the optimization changes the output. Evergreen is failing because of that.

I was wondering if that would be the case.

Updating now.

@rstam rstam requested a review from adelinowona April 1, 2025 15:18
adelinowona
adelinowona approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@adelinowona adelinowona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adelinowona adelinowona adelinowona approved these changes

@sanych-sun sanych-sun Awaiting requested review from sanych-sun

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rstam @adelinowona