CDRIVER-6125 fix GridFS chunk size handling #2146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not strictly needed. But gives an earlier error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip-ci] Tested with this patch build: https://spruce.mongodb.com/version/68e9597d5a19210007dc3e69
See CDRIVER-6125 for details and links to the original report.
Notably: a negative the
lengthfield does not trigger the same issue. But a check is added to error earlier. Otherwise a negativelengthtriggers a later error in_mongoc_gridfs_bucket_read_chunk. This check could be reverted if it seems unnecessary.