CDRIVER-6011 fix message of bson_strerror_r on Windows
#2011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
changed the title
bson_strerror_r on Windowsbson_strerror_r on Windows
kevinAlbs
requested review from
vector-of-bool and
eramongodb
and removed request for
vector-of-bool
eramongodb
approved these changes
May 14, 2025
Co-authored-by: Ezra Chung <[email protected]>
Thank you. I missed it too in review. I fortunately happened to spot this when seeing an "Unknown error" testing bad file paths. |
kevinAlbs
added a commit
to kevinAlbs/mongo-c-driver
that referenced
this pull request
May 14, 2025
--------- Co-authored-by: Ezra Chung <[email protected]>
kevinAlbs
added a commit
to kevinAlbs/mongo-c-driver
that referenced
this pull request
May 14, 2025
--------- Co-authored-by: Ezra Chung <[email protected]>
kevinAlbs
added a commit
that referenced
this pull request
May 14, 2025
--------- Co-authored-by: Ezra Chung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flipped check of
strerror_s. This caused calls ofbson_strerror_ron Windows to output "Unknown error" on known error codes.Discovered when working on #2009.