CLOUDP-352308 Enhanced CLI options for robust linking #3311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2173cec The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nima-taheri-mongodb
changed the title
nima-taheri-mongodb
changed the title
Contributor
|
Size Change: +1.76 kB (+0.1%) Total Size: 1.79 MB
ℹ️ View Unchanged
|
nima-taheri-mongodb
requested review from
adamrasheed
and removed request for
a team
tools/cli/src/index.ts
Outdated
| .option( | ||
| '--no-parallel', | ||
| 'Run the link command sequentially for each package. Useful for debugging or when the parallel approach fails', | ||
| true, |
Collaborator
There was a problem hiding this comment.
should the default be false (default parallel)?
Collaborator
Author
There was a problem hiding this comment.
It's really confusing, I know. But it works. I could only verify through manual testing that the true value here means the default value for parallel is true.
Collaborator
There was a problem hiding this comment.
Should we change the name of the arg then to --parallel?
Collaborator
Author
There was a problem hiding this comment.
if I do so --no-parallel or --parallel=false wouldn't work. 🤦
(another reason in favour of using simple shell script 😛)
Collaborator
There was a problem hiding this comment.
Ok I see what's happening. Since the name is --no-parallel, Commander automatically turns that into the parallel option, but it doesn't seem to be automatically flipping it as the docs would suggest. https://github.com/tj/commander.js?tab=readme-ov-file#other-option-types-negatable-boolean-and-booleanvalue
If I add parallel to the verbose logs in link.ts I can see that parallel is true by default, even though it would seem that --no-parallel being true would set parallel to false
Collaborator
There was a problem hiding this comment.
Either removing the default value or adding an additional .option('--parallel', '...', true) seems to satisfy Commander
Collaborator
Author
There was a problem hiding this comment.
removing the default value sounds like a good way to make this less confusing, added it.
nima-taheri-mongodb
force-pushed
the
cloudp-352308-robust-link-flags
branch
from
b3416b0 to
b5e3774
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the CLI linking utility with new options to handle edge cases in different development environments. It introduces two flags: --no-parallel to disable parallel linking (defaulting to parallel execution), and --launch-env to provide custom environment variables for spawned processes.
Key Changes:
- Added sequential linking support as an alternative to parallel execution
- Added custom environment variable support for spawned link processes
- Improved package name matching to support both scoped and unscoped formats
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/link/src/utils/linkPackagesForScope.ts | Added parallel/sequential execution logic, environment variable threading, and improved package name matching |
| tools/link/src/utils/linkPackageTo.ts | Added environment variable parameter to link destination function |
| tools/link/src/utils/install.ts | Added environment variable parameter to install function |
| tools/link/src/utils/createLinkFrom.ts | Added environment variable parameter to link source function |
| tools/link/src/link.ts | Added CLI option parsing for parallel flag and launch environment string |
| tools/cli/src/index.ts | Added CLI flag definitions for --no-parallel and --launch-env options |
| DEVELOPER.md | Updated documentation with troubleshooting guidance for linking issues |
| .changeset/giant-phones-jog.md | Added changeset entry documenting the new features |
DEVELOPER.md
Outdated
| #### 6. Publishing additional versions | ||
|
|
||
| To publish additional versions, manually the version number in `packages/<package-name>/package.json`, and re-run step 4. Then, either manually update the external project's `package.json`, or re-run `yarn install @leafygreen-ui/<package-name>`. | ||
| To publish additional versions, manually the version number in `packages/<package-name>/package.json`, and re-run step 4. Then, either manually update the external project's `package.json`, or re-run `pnpm install @leafygreen-ui/<package-name>`. |
There was a problem hiding this comment.
Missing verb in sentence. Should be 'manually update the version number' or 'manually change the version number'.
Suggested change
| To publish additional versions, manually the version number in `packages/<package-name>/package.json`, and re-run step 4. Then, either manually update the external project's `package.json`, or re-run `pnpm install @leafygreen-ui/<package-name>`. | |
| To publish additional versions, manually update the version number in `packages/<package-name>/package.json`, and re-run step 4. Then, either manually update the external project's `package.json`, or re-run `pnpm install @leafygreen-ui/<package-name>`. |
Collaborator
Author
There was a problem hiding this comment.
done. I also noticed that there's another documentation of pnpm link script in README.md along with the documentation of DEVELOPER.md. consolidated them.
Collaborator
Author
There was a problem hiding this comment.
Hey @TheSonOfThomp, I thought about this a bit more and I have an alternative proposal. We use a simple shell script for this job. My reasoning:
- Since this job is essentially a script job, shell is the simplest tool for the job. easy to read, debug, and tweak if needed.
- It doesn't have the environment variable pollution issue that pnpm scripts have.
- We can use
turbo lsscript to fetch the list of packages to link, and use the same--filterof turbo to limit the linking to specific packages (no need for--scopeor--packages)
Here's a POC with almost all features that the current tool has in 140 lines of code:
#!/usr/bin/env bash
set -e
set -o pipefail
target=""
turbo_args=()
npm="pnpm"
parallel=true
cwd=$(pwd)
color_debug="\033[2m" # dim text
color_error="\033[31m" # red text
color_reset="\033[0m" # reset text color
# print the usage message
function print_usage() {
echo "Usage: $0 [--npm | --yarn | --pnpm] [--no-parallel] [--filter=<filter>] <target-path>"
echo ""
echo "Options:"
echo " --npm: Use npm as the package manager"
echo " --yarn: Use yarn as the package manager"
echo " --pnpm: Use pnpm as the package manager"
echo " --no-parallel: Run the link command sequentially for each package. Useful for debugging or when the parallel approach fails"
echo " --filter: Filter the packages to link. Use turbo filter syntax. e.g. '--filter=@lg-charts/*'"
echo " --help: Print this help message"
echo ""
echo "Example: $0 --pnpm --no-parallel --filter='@lg-charts/*' ."
echo "Example: $0 --pnpm --no-parallel --filter='@lg-charts/core' --filter='@lg-tools/*' ."
echo ""
}
# parse the arguments
for arg in "$@"; do
if [[ "$arg" == "--npm" ]]; then
npm="npm"
elif [[ "$arg" == "--yarn" ]]; then
npm="yarn"
elif [[ "$arg" == "--pnpm" ]]; then
npm="pnpm"
elif [[ "$arg" =~ ^--filter= ]]; then
turbo_args+=("$arg")
elif [[ "$arg" == "--no-parallel" ]]; then
parallel=false
elif [[ "$arg" == "--help" ]]; then
print_usage
exit 0
elif [[ "$arg" =~ ^-- ]]; then
echo "Unknown option: $arg"
print_usage
exit 1
else
if [[ -z "$target" ]]; then
target="$arg"
else
echo "Only a single positional argument is supported to specify the target path"
print_usage
exit 1
fi
fi
done
if [[ -z "$target" ]]; then
echo "No target path specified"
print_usage
exit 1
fi
# run a command and print the output with a prefix
function run!() {
# named arguments
local prefix command
local "${@}"
echo -e "${prefix} ${color_debug}→${color_reset} ${command}"
set +e
{
(eval "${command}") \
2> >(while IFS= read -r line; do echo -e "${prefix} ${color_error}$line${color_reset}"; done) \
1> >(while IFS= read -r line; do echo -e "${prefix} ${color_debug}$line${color_reset}"; done)
}
local exit_code=$?
set -e
if [[ $exit_code -ne 0 ]]; then
echo -e "${prefix} ${color_debug}✖${color_reset} ${color_error}failed with exit code $exit_code${color_reset}"
else
echo -e "${prefix} ${color_debug}✔${color_reset} ${color_debug}finished successfully${color_reset}"
fi
return $exit_code
}
function get_random_color() {
local color_options=(
"\033[32m" # Green
"\033[33m" # Yellow
"\033[34m" # Blue
"\033[35m" # Magenta
"\033[36m" # Cyan
"\033[92m" # Bright Green
"\033[93m" # Bright Yellow
"\033[94m" # Bright Blue
"\033[95m" # Bright Magenta
"\033[96m" # Bright Cyan
)
echo "${color_options[$((RANDOM % ${#color_options[@]}))]}"
}
# link a package from the from_path to the to_path
function link_package() {
# named arguments
local name from_path to_path
local "${@}"
local prefix="$(get_random_color)[$name]${color_reset}"
run! prefix="$prefix" command="cd $from_path && $npm link"
run! prefix="$prefix" command="cd $to_path && $npm link $name"
}
packages=$($npm turbo ls ${turbo_args[@]} --output=json | jq -r '.packages.items[]? | "\(.path)|\(.name)"')
running_pids=()
for package in $packages; do
IFS='|' read -r path name <<<"$package"
if [[ $parallel == true ]]; then
link_package name="$name" from_path="$path" to_path="$target" &
running_pids+=($!)
else
link_package name="$name" from_path="$path" to_path="$target"
fi
done
if [[ $parallel == true ]]; then
for pid in "${running_pids[@]}"; do
wait "$pid"
done
fi
Collaborator
There was a problem hiding this comment.
I like the idea, but I think I'd prefer keeping this a JS script, for the simple reason that the maintainers of this repo are primarily JS devs, and maintaining that would be easier than a complex shell script
Collaborator
Author
There was a problem hiding this comment.
Fair point! Quick story, at my last company (Hootsuite), our team initially wrote a lot of our build and dev-tooling scripts in SBT/Scala since that was our main language. But as time went on, we found Scala's power actually led to over-complicated scripts that were tough to debug and maintain. Eventually, we decided to migrate everything back to long but simple shell scripts and found things easier to manage.
I did not plan this at all 😂 but #3319 just emerged to help my side of argument.
Another point in favor of shell scripts is that modern DevOps culture expects developers to be comfortable with operational tasks including scripting, so having basic shell scripting skills is pretty much essential. Plus, with LLMs available, writing and interpreting shell scripts is easier than ever.
So I'm still a fan of shell scripts for these kinds of tools, but I'll defer to whatever your team prefers!
nima-taheri-mongodb
force-pushed
the
cloudp-352308-robust-link-flags
branch
from
b5e3774 to
521851c
Compare
Collaborator
Author
|
👆 rebased |
Comment on lines
21
to
23
| verbose?: boolean, | ||
| parallel?: boolean, | ||
| launchEnv?: NodeJS.ProcessEnv, |
Collaborator
There was a problem hiding this comment.
nit: I'd probably recommend turning this into an options object at this point
Collaborator
Author
There was a problem hiding this comment.
good call, applied.
tools/cli/src/index.ts
Outdated
| .option( | ||
| '--no-parallel', | ||
| 'Run the link command sequentially for each package. Useful for debugging or when the parallel approach fails', | ||
| true, |
Collaborator
There was a problem hiding this comment.
Ok I see what's happening. Since the name is --no-parallel, Commander automatically turns that into the parallel option, but it doesn't seem to be automatically flipping it as the docs would suggest. https://github.com/tj/commander.js?tab=readme-ov-file#other-option-types-negatable-boolean-and-booleanvalue
If I add parallel to the verbose logs in link.ts I can see that parallel is true by default, even though it would seem that --no-parallel being true would set parallel to false
tools/cli/src/index.ts
Outdated
| .option( | ||
| '--no-parallel', | ||
| 'Run the link command sequentially for each package. Useful for debugging or when the parallel approach fails', | ||
| true, |
Collaborator
There was a problem hiding this comment.
Either removing the default value or adding an additional .option('--parallel', '...', true) seems to satisfy Commander
Contributor
|
Coverage after merging cloudp-352308-robust-link-flags into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
TheSonOfThomp
approved these changes
Nov 20, 2025
TheSonOfThomp
added a commit
that referenced
this pull request
Nov 20, 2025
commit eb49bd0 Merge: d525c25 43810b4 Author: Adam Thompson <[email protected]> Date: Thu Nov 20 13:25:10 2025 -0500 Merge branch 'main' into at/canvas-header commit 43810b4 Author: Nima Taheri <[email protected]> Date: Wed Nov 19 15:30:29 2025 -0800 LG-5635 fix unexpected @emotion imports in umd bundle of icons (#3319) * feat: stricter post-build check on icon package * fix: not waiting for promises to finish commit d525c25 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:41:59 2025 -0500 fixes commit a35da52 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:30:04 2025 -0500 changeset commit b2c94c0 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:28:11 2025 -0500 update stories commit 4142151 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:27:59 2025 -0500 package json commit 3e09cf2 Merge: ec4fad8 e0d0b02 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:18:17 2025 -0500 Add 'packages/canvas-header/' from commit 'e0d0b0293e1981eefa8b8a4df9a37926532356b6' git-subtree-dir: packages/canvas-header git-subtree-mainline: ec4fad8 git-subtree-split: e0d0b02 commit ec4fad8 Author: Adam Rasheed <[email protected]> Date: Wed Nov 19 12:35:14 2025 -0800 [LG-5748] chore: Add Text and Border Color Variants (#3321) * [LG-5748] chore: Add Text and Border Color Variants * updated changset commit d816392 Author: Adam Thompson <[email protected]> Date: Wed Nov 19 14:44:05 2025 -0500 LG-5740 fix(LoadingIndicator) fixes spinner type references (#3315) * Update package.json * Create loading-spinner-types.md commit 55580b8 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 16:32:50 2025 -0500 [LG-2957] feat: GuideCue - Update Button Focus (#3277) * [LG-2957] feat: GuideCue - Update Button Focus * comment cleanup * udpated changelog, udpated test assertion commit d8485a9 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 14:16:13 2025 -0500 [LG-5666] MCP-UI App Scaffolding (#3280) * [LG-5666] MCP-UI App Scaffolding * Added component, sdk scaffolding, package json updates * cleanup * fixed linting * updated workspace * added tsconfig * updated build * r17 updates * updated turbo settings * added devDeps * rm sdk, changed directory structure, updated listdb styles * fix: r17 scripts (#3305) * update r17 scripts * filter apps from r17 build workflow * add mcpui to caches --------- Co-authored-by: Adam Thompson <[email protected]> commit c7d6e62 Author: Stephen Lee <[email protected]> Date: Fri Nov 14 07:14:00 2025 -0800 feat(popover): pass through popover enum types (#3302) * feat(combobox): export RenderMode enum from popover package * chore(combobox): changeset * feat(date-picker): export Align and Justify enums from popover package * chore(date-picker): changeset * feat(guide-cue): export BeaconAlign enum * chore(guide-cue): changeset * feat(menu): export Align, Justify, and RenderMode enums from popover package * chore(menu): changeset * feat(split-button): export RenderMode and make popover package dev dep * chore(split-button): changeset * refactor(split-button): consolidate menu imports * refactor(split-button): rename imported enums commit d7e989b Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Nov 13 23:42:07 2025 +0000 Version Packages (#3313) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit 999febf Author: Nima Taheri <[email protected]> Date: Thu Nov 13 15:01:26 2025 -0800 CLOUDP-352308 add logging for spawn processes in link tools (#3310) * feat: enable logging for spawn processes * docs: add changelog * refactor: as co-pilot suggested test: add unit test commit 587f14e Author: Stephen Lee <[email protected]> Date: Thu Nov 13 14:03:47 2025 -0800 fix(modal): add explicit margin auto to dialog element styles (#3312) * fix(modal): add explicit margin * chore(modal): changeset commit e0d0b02 Author: Adam Thompson <[email protected]> Date: Wed Jun 18 12:44:57 2025 -0400 PNPM + Storybook 8 (private) (#426) * pnpm import * Delete yarn.lock * workflows * yarn -> pnpm docs * workspace:^ * add missing global packages * @storybook/test * story ts fixes * Adds missing peers * rm lg.json * bump base lg * fix product icon builds * fix sb * bump peer deps * rm pnpm/action-setup@v4 * Revert "rm pnpm/action-setup@v4" This reverts commit 14198eb258e958ddaa0e480fee17cfddec5ce6fd. * Update pnpm-lock.yaml * apk * apk all * wget * restore pnpm * specific pnpm action * workspace * lint fix * tools @ latest * minor lint errors * tools build dev deps * typescript * tsconfig * package exports * ts fixes * Create rollup.config.mjs * lint * checkout main src * ts fixes * lint * isolated async tests * Update CloudNav.analytics.spec.tsx * skip mongonav tests * feature walls tests * Create rollup.config.mjs * lint fix * Update pr.yml * Update release.yml * cache/restore * chromatic + pnpm * update cache restore paths * cache save path * addon 0.5.2-next.0 * addon 0.5.2-next.2 commit 0d81bf1 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Mar 26 17:51:47 2025 +0000 Version Packages (#411) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 4445f18 Author: Shaneeza <[email protected]> Date: Tue Mar 25 16:06:42 2025 -0400 Update CanvasHeader live example for .design (#418) * update live example for .design * remove extra characters * changeset commit 12ba130 Author: Adam Thompson <[email protected]> Date: Thu Mar 13 16:14:08 2025 -0400 Canvas Header updates [LG-4938, LG-4958] (#406) * updates LiveExample * rm bg styles * fix icon spacing * fix "copied" tooltip alignment * Create canvas-header-bg.md * fix build * Update CanvasHeader.stories.tsx commit 7bb4d90 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Jan 21 13:28:01 2025 -0500 Version Packages (#343) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 82b1696 Author: Adam Thompson <[email protected]> Date: Thu Jan 9 15:55:54 2025 -0500 Updates Popover/Menu/Tooltip to TopLayer LG-4746 (#337) * bump other packages * major popover updates * bump provider * bump global provider * bump cli * rm popoverZIndex * Create forty-days-rest.md * Delete .eslintignore * update lg to latest major * Removes prop-types, and bump LG packages * lint * Update .eslintrc.js * update storybook @lg-tools/storybook-utils * lint commit f6a8aca Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Dec 2 18:51:14 2024 +0000 Version Packages (#298) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 580a4f0 Author: Adam Thompson <[email protected]> Date: Tue Nov 26 13:30:34 2024 -0500 Canvas header resource badges [LG-4675] (#299) * adds `resourceBadges` prop * Create breezy-crabs-camp.md * Update breezy-crabs-camp.md * WIP: copy button overlay * rm space * adds faker * update copy button interaction styling * downgrade faker * Update CanvasHeader.stories.tsx * fix typo in changeset * add proptypes * conditionally render resourceBadges wrapper * add dark mode styles * add bg color * Update CanvasHeader.stories.tsx * Update CanvasHeader.stories.tsx * improve focus styles commit df6a1e4 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jul 15 15:22:38 2024 -0700 Version Packages (#184) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit f5b9063 Author: Stephen Lee <[email protected]> Date: Fri Jul 12 13:43:09 2024 -0700 Fix naming of lg-private packages (#183) * Fix lg-private packages naming * Changeset commit a068930 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jul 11 13:15:56 2024 -0700 Version Packages (#177) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 2abf344 Author: Shaneeza <[email protected]> Date: Wed Jul 3 12:33:13 2024 -0400 LG-4058: add badges to `CanvasHeader` (#176) * add badges to canvasheader * changeset * ids * one line example * one line again * use color tokens * forgot to save * bump dependencies * add storybook dep * break out stories * remove multiple action story * feedback commit ee1af09 Author: Adam Thompson <[email protected]> Date: Tue Apr 9 16:48:41 2024 -0400 Updates manual publishing docs (#125) * Update .npmrc * merge npmrc * merge npmrc * update registry * Update README.md * typo * Update .npmrc commit 338ba02 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Apr 9 13:24:37 2024 -0400 Version Packages (#123) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit de15015 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Mar 26 12:13:21 2024 -0400 Version Packages (#102) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 141bfd0 Author: Adam Thompson <[email protected]> Date: Wed Mar 6 14:41:54 2024 -0500 Bump `@leafygreen-ui` & `@lg-tools` dependencies (#115) * bump lg-tools deps * bumps cloud nav deps * bump canvas header deps * Create loud-melons-remain.md * Update shared-pr.yml * updates build cache key * Update package.json * chromatic needs build commit 6c33cd5 Author: Adam Thompson <[email protected]> Date: Wed Feb 28 17:20:03 2024 -0500 Use `chromaui/action` (#113) * bump react types resolutions * fix resolutions * uses chromaui/action * expect prop types error * bump chromatic * mv chromatic job * Update yarn.lock commit 9dabc6a Author: Shaneeza <[email protected]> Date: Mon Feb 26 14:25:36 2024 -0500 bump changeset (#110) commit e1e1437 Author: Shaneeza <[email protected]> Date: Mon Feb 26 13:20:18 2024 -0500 LG-3949: canvasHeader component (#106) * WIP * div * wip * fix copy icon underline * add opacity * hover and focus styles * add copy func * add todo test * small tweaks * min-height * storybook * remove comments * story link * wip adding tests * remove mock stuff * resource tests * more resource tests * tests * remove backLink component * clean up * show copy icon with tooltip * some fixes * lint * readme * change package name * clean up * changeset * lint * testing * adressing brooke comments * sandy feedback * add BackLink component * forgot to save * brooke feedback * update generated story * fix z-index issue * spacing between page title and resource name * spacing between page title and resource name again * add top and bottom margin * testing * remove some controls * testing * testing * update testid * remove z-index; no longer needed * bump typography * test * test --------- Co-authored-by: Adam Thompson <[email protected]> Squashed commit of the following: commit b1e22ce Merge: 84e889e ee58160 Author: Adam Thompson <[email protected]> Date: Thu Nov 20 16:17:28 2025 -0500 Merge branch 'main' into at/canvas-header commit 84e889e Author: Adam Thompson <[email protected]> Date: Thu Nov 20 15:27:47 2025 -0500 Update .changeset/canvas-header.md Co-authored-by: Stephen Lee <[email protected]> commit 01049b2 Author: Adam Michael Thompson <[email protected]> Date: Thu Nov 20 15:24:22 2025 -0500 Update tsconfig.json commit ee58160 Author: Nima Taheri <[email protected]> Date: Thu Nov 20 11:55:41 2025 -0800 CLOUDP-352308 Enhanced CLI options for robust linking (#3311) * feat: update CLI options for improved linking process * docs: add changelog * docs: apply review feedback * apply: review comments + docs update * apply: review comments (2) commit eb49bd0 Merge: d525c25 43810b4 Author: Adam Thompson <[email protected]> Date: Thu Nov 20 13:25:10 2025 -0500 Merge branch 'main' into at/canvas-header commit 43810b4 Author: Nima Taheri <[email protected]> Date: Wed Nov 19 15:30:29 2025 -0800 LG-5635 fix unexpected @emotion imports in umd bundle of icons (#3319) * feat: stricter post-build check on icon package * fix: not waiting for promises to finish commit d525c25 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:41:59 2025 -0500 fixes commit a35da52 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:30:04 2025 -0500 changeset commit b2c94c0 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:28:11 2025 -0500 update stories commit 4142151 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:27:59 2025 -0500 package json commit 3e09cf2 Merge: ec4fad8 e0d0b02 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:18:17 2025 -0500 Add 'packages/canvas-header/' from commit 'e0d0b0293e1981eefa8b8a4df9a37926532356b6' git-subtree-dir: packages/canvas-header git-subtree-mainline: ec4fad8 git-subtree-split: e0d0b02 commit ec4fad8 Author: Adam Rasheed <[email protected]> Date: Wed Nov 19 12:35:14 2025 -0800 [LG-5748] chore: Add Text and Border Color Variants (#3321) * [LG-5748] chore: Add Text and Border Color Variants * updated changset commit d816392 Author: Adam Thompson <[email protected]> Date: Wed Nov 19 14:44:05 2025 -0500 LG-5740 fix(LoadingIndicator) fixes spinner type references (#3315) * Update package.json * Create loading-spinner-types.md commit 55580b8 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 16:32:50 2025 -0500 [LG-2957] feat: GuideCue - Update Button Focus (#3277) * [LG-2957] feat: GuideCue - Update Button Focus * comment cleanup * udpated changelog, udpated test assertion commit d8485a9 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 14:16:13 2025 -0500 [LG-5666] MCP-UI App Scaffolding (#3280) * [LG-5666] MCP-UI App Scaffolding * Added component, sdk scaffolding, package json updates * cleanup * fixed linting * updated workspace * added tsconfig * updated build * r17 updates * updated turbo settings * added devDeps * rm sdk, changed directory structure, updated listdb styles * fix: r17 scripts (#3305) * update r17 scripts * filter apps from r17 build workflow * add mcpui to caches --------- Co-authored-by: Adam Thompson <[email protected]> commit c7d6e62 Author: Stephen Lee <[email protected]> Date: Fri Nov 14 07:14:00 2025 -0800 feat(popover): pass through popover enum types (#3302) * feat(combobox): export RenderMode enum from popover package * chore(combobox): changeset * feat(date-picker): export Align and Justify enums from popover package * chore(date-picker): changeset * feat(guide-cue): export BeaconAlign enum * chore(guide-cue): changeset * feat(menu): export Align, Justify, and RenderMode enums from popover package * chore(menu): changeset * feat(split-button): export RenderMode and make popover package dev dep * chore(split-button): changeset * refactor(split-button): consolidate menu imports * refactor(split-button): rename imported enums commit d7e989b Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Nov 13 23:42:07 2025 +0000 Version Packages (#3313) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit 999febf Author: Nima Taheri <[email protected]> Date: Thu Nov 13 15:01:26 2025 -0800 CLOUDP-352308 add logging for spawn processes in link tools (#3310) * feat: enable logging for spawn processes * docs: add changelog * refactor: as co-pilot suggested test: add unit test commit 587f14e Author: Stephen Lee <[email protected]> Date: Thu Nov 13 14:03:47 2025 -0800 fix(modal): add explicit margin auto to dialog element styles (#3312) * fix(modal): add explicit margin * chore(modal): changeset commit e0d0b02 Author: Adam Thompson <[email protected]> Date: Wed Jun 18 12:44:57 2025 -0400 PNPM + Storybook 8 (private) (#426) * pnpm import * Delete yarn.lock * workflows * yarn -> pnpm docs * workspace:^ * add missing global packages * @storybook/test * story ts fixes * Adds missing peers * rm lg.json * bump base lg * fix product icon builds * fix sb * bump peer deps * rm pnpm/action-setup@v4 * Revert "rm pnpm/action-setup@v4" This reverts commit 14198eb258e958ddaa0e480fee17cfddec5ce6fd. * Update pnpm-lock.yaml * apk * apk all * wget * restore pnpm * specific pnpm action * workspace * lint fix * tools @ latest * minor lint errors * tools build dev deps * typescript * tsconfig * package exports * ts fixes * Create rollup.config.mjs * lint * checkout main src * ts fixes * lint * isolated async tests * Update CloudNav.analytics.spec.tsx * skip mongonav tests * feature walls tests * Create rollup.config.mjs * lint fix * Update pr.yml * Update release.yml * cache/restore * chromatic + pnpm * update cache restore paths * cache save path * addon 0.5.2-next.0 * addon 0.5.2-next.2 commit 0d81bf1 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Mar 26 17:51:47 2025 +0000 Version Packages (#411) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 4445f18 Author: Shaneeza <[email protected]> Date: Tue Mar 25 16:06:42 2025 -0400 Update CanvasHeader live example for .design (#418) * update live example for .design * remove extra characters * changeset commit 12ba130 Author: Adam Thompson <[email protected]> Date: Thu Mar 13 16:14:08 2025 -0400 Canvas Header updates [LG-4938, LG-4958] (#406) * updates LiveExample * rm bg styles * fix icon spacing * fix "copied" tooltip alignment * Create canvas-header-bg.md * fix build * Update CanvasHeader.stories.tsx commit 7bb4d90 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Jan 21 13:28:01 2025 -0500 Version Packages (#343) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 82b1696 Author: Adam Thompson <[email protected]> Date: Thu Jan 9 15:55:54 2025 -0500 Updates Popover/Menu/Tooltip to TopLayer LG-4746 (#337) * bump other packages * major popover updates * bump provider * bump global provider * bump cli * rm popoverZIndex * Create forty-days-rest.md * Delete .eslintignore * update lg to latest major * Removes prop-types, and bump LG packages * lint * Update .eslintrc.js * update storybook @lg-tools/storybook-utils * lint commit f6a8aca Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Dec 2 18:51:14 2024 +0000 Version Packages (#298) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 580a4f0 Author: Adam Thompson <[email protected]> Date: Tue Nov 26 13:30:34 2024 -0500 Canvas header resource badges [LG-4675] (#299) * adds `resourceBadges` prop * Create breezy-crabs-camp.md * Update breezy-crabs-camp.md * WIP: copy button overlay * rm space * adds faker * update copy button interaction styling * downgrade faker * Update CanvasHeader.stories.tsx * fix typo in changeset * add proptypes * conditionally render resourceBadges wrapper * add dark mode styles * add bg color * Update CanvasHeader.stories.tsx * Update CanvasHeader.stories.tsx * improve focus styles commit df6a1e4 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jul 15 15:22:38 2024 -0700 Version Packages (#184) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit f5b9063 Author: Stephen Lee <[email protected]> Date: Fri Jul 12 13:43:09 2024 -0700 Fix naming of lg-private packages (#183) * Fix lg-private packages naming * Changeset commit a068930 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jul 11 13:15:56 2024 -0700 Version Packages (#177) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 2abf344 Author: Shaneeza <[email protected]> Date: Wed Jul 3 12:33:13 2024 -0400 LG-4058: add badges to `CanvasHeader` (#176) * add badges to canvasheader * changeset * ids * one line example * one line again * use color tokens * forgot to save * bump dependencies * add storybook dep * break out stories * remove multiple action story * feedback commit ee1af09 Author: Adam Thompson <[email protected]> Date: Tue Apr 9 16:48:41 2024 -0400 Updates manual publishing docs (#125) * Update .npmrc * merge npmrc * merge npmrc * update registry * Update README.md * typo * Update .npmrc commit 338ba02 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Apr 9 13:24:37 2024 -0400 Version Packages (#123) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit de15015 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Mar 26 12:13:21 2024 -0400 Version Packages (#102) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 141bfd0 Author: Adam Thompson <[email protected]> Date: Wed Mar 6 14:41:54 2024 -0500 Bump `@leafygreen-ui` & `@lg-tools` dependencies (#115) * bump lg-tools deps * bumps cloud nav deps * bump canvas header deps * Create loud-melons-remain.md * Update shared-pr.yml * updates build cache key * Update package.json * chromatic needs build commit 6c33cd5 Author: Adam Thompson <[email protected]> Date: Wed Feb 28 17:20:03 2024 -0500 Use `chromaui/action` (#113) * bump react types resolutions * fix resolutions * uses chromaui/action * expect prop types error * bump chromatic * mv chromatic job * Update yarn.lock commit 9dabc6a Author: Shaneeza <[email protected]> Date: Mon Feb 26 14:25:36 2024 -0500 bump changeset (#110) commit e1e1437 Author: Shaneeza <[email protected]> Date: Mon Feb 26 13:20:18 2024 -0500 LG-3949: canvasHeader component (#106) * WIP * div * wip * fix copy icon underline * add opacity * hover and focus styles * add copy func * add todo test * small tweaks * min-height * storybook * remove comments * story link * wip adding tests * remove mock stuff * resource tests * more resource tests * tests * remove backLink component * clean up * show copy icon with tooltip * some fixes * lint * readme * change package name * clean up * changeset * lint * testing * adressing brooke comments * sandy feedback * add BackLink component * forgot to save * brooke feedback * update generated story * fix z-index issue * spacing between page title and resource name * spacing between page title and resource name again * add top and bottom margin * testing * remove some controls * testing * testing * update testid * remove z-index; no longer needed * bump typography * test * test --------- Co-authored-by: Adam Thompson <[email protected]>
TheSonOfThomp
added a commit
that referenced
this pull request
Nov 21, 2025
commit eb49bd0 Merge: d525c25 43810b4 Author: Adam Thompson <[email protected]> Date: Thu Nov 20 13:25:10 2025 -0500 Merge branch 'main' into at/canvas-header commit 43810b4 Author: Nima Taheri <[email protected]> Date: Wed Nov 19 15:30:29 2025 -0800 LG-5635 fix unexpected @emotion imports in umd bundle of icons (#3319) * feat: stricter post-build check on icon package * fix: not waiting for promises to finish commit d525c25 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:41:59 2025 -0500 fixes commit a35da52 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:30:04 2025 -0500 changeset commit b2c94c0 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:28:11 2025 -0500 update stories commit 4142151 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:27:59 2025 -0500 package json commit 3e09cf2 Merge: ec4fad8 e0d0b02 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:18:17 2025 -0500 Add 'packages/canvas-header/' from commit 'e0d0b0293e1981eefa8b8a4df9a37926532356b6' git-subtree-dir: packages/canvas-header git-subtree-mainline: ec4fad8 git-subtree-split: e0d0b02 commit ec4fad8 Author: Adam Rasheed <[email protected]> Date: Wed Nov 19 12:35:14 2025 -0800 [LG-5748] chore: Add Text and Border Color Variants (#3321) * [LG-5748] chore: Add Text and Border Color Variants * updated changset commit d816392 Author: Adam Thompson <[email protected]> Date: Wed Nov 19 14:44:05 2025 -0500 LG-5740 fix(LoadingIndicator) fixes spinner type references (#3315) * Update package.json * Create loading-spinner-types.md commit 55580b8 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 16:32:50 2025 -0500 [LG-2957] feat: GuideCue - Update Button Focus (#3277) * [LG-2957] feat: GuideCue - Update Button Focus * comment cleanup * udpated changelog, udpated test assertion commit d8485a9 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 14:16:13 2025 -0500 [LG-5666] MCP-UI App Scaffolding (#3280) * [LG-5666] MCP-UI App Scaffolding * Added component, sdk scaffolding, package json updates * cleanup * fixed linting * updated workspace * added tsconfig * updated build * r17 updates * updated turbo settings * added devDeps * rm sdk, changed directory structure, updated listdb styles * fix: r17 scripts (#3305) * update r17 scripts * filter apps from r17 build workflow * add mcpui to caches --------- Co-authored-by: Adam Thompson <[email protected]> commit c7d6e62 Author: Stephen Lee <[email protected]> Date: Fri Nov 14 07:14:00 2025 -0800 feat(popover): pass through popover enum types (#3302) * feat(combobox): export RenderMode enum from popover package * chore(combobox): changeset * feat(date-picker): export Align and Justify enums from popover package * chore(date-picker): changeset * feat(guide-cue): export BeaconAlign enum * chore(guide-cue): changeset * feat(menu): export Align, Justify, and RenderMode enums from popover package * chore(menu): changeset * feat(split-button): export RenderMode and make popover package dev dep * chore(split-button): changeset * refactor(split-button): consolidate menu imports * refactor(split-button): rename imported enums commit d7e989b Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Nov 13 23:42:07 2025 +0000 Version Packages (#3313) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit 999febf Author: Nima Taheri <[email protected]> Date: Thu Nov 13 15:01:26 2025 -0800 CLOUDP-352308 add logging for spawn processes in link tools (#3310) * feat: enable logging for spawn processes * docs: add changelog * refactor: as co-pilot suggested test: add unit test commit 587f14e Author: Stephen Lee <[email protected]> Date: Thu Nov 13 14:03:47 2025 -0800 fix(modal): add explicit margin auto to dialog element styles (#3312) * fix(modal): add explicit margin * chore(modal): changeset commit e0d0b02 Author: Adam Thompson <[email protected]> Date: Wed Jun 18 12:44:57 2025 -0400 PNPM + Storybook 8 (private) (#426) * pnpm import * Delete yarn.lock * workflows * yarn -> pnpm docs * workspace:^ * add missing global packages * @storybook/test * story ts fixes * Adds missing peers * rm lg.json * bump base lg * fix product icon builds * fix sb * bump peer deps * rm pnpm/action-setup@v4 * Revert "rm pnpm/action-setup@v4" This reverts commit 14198eb258e958ddaa0e480fee17cfddec5ce6fd. * Update pnpm-lock.yaml * apk * apk all * wget * restore pnpm * specific pnpm action * workspace * lint fix * tools @ latest * minor lint errors * tools build dev deps * typescript * tsconfig * package exports * ts fixes * Create rollup.config.mjs * lint * checkout main src * ts fixes * lint * isolated async tests * Update CloudNav.analytics.spec.tsx * skip mongonav tests * feature walls tests * Create rollup.config.mjs * lint fix * Update pr.yml * Update release.yml * cache/restore * chromatic + pnpm * update cache restore paths * cache save path * addon 0.5.2-next.0 * addon 0.5.2-next.2 commit 0d81bf1 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Mar 26 17:51:47 2025 +0000 Version Packages (#411) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 4445f18 Author: Shaneeza <[email protected]> Date: Tue Mar 25 16:06:42 2025 -0400 Update CanvasHeader live example for .design (#418) * update live example for .design * remove extra characters * changeset commit 12ba130 Author: Adam Thompson <[email protected]> Date: Thu Mar 13 16:14:08 2025 -0400 Canvas Header updates [LG-4938, LG-4958] (#406) * updates LiveExample * rm bg styles * fix icon spacing * fix "copied" tooltip alignment * Create canvas-header-bg.md * fix build * Update CanvasHeader.stories.tsx commit 7bb4d90 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Jan 21 13:28:01 2025 -0500 Version Packages (#343) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 82b1696 Author: Adam Thompson <[email protected]> Date: Thu Jan 9 15:55:54 2025 -0500 Updates Popover/Menu/Tooltip to TopLayer LG-4746 (#337) * bump other packages * major popover updates * bump provider * bump global provider * bump cli * rm popoverZIndex * Create forty-days-rest.md * Delete .eslintignore * update lg to latest major * Removes prop-types, and bump LG packages * lint * Update .eslintrc.js * update storybook @lg-tools/storybook-utils * lint commit f6a8aca Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Dec 2 18:51:14 2024 +0000 Version Packages (#298) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 580a4f0 Author: Adam Thompson <[email protected]> Date: Tue Nov 26 13:30:34 2024 -0500 Canvas header resource badges [LG-4675] (#299) * adds `resourceBadges` prop * Create breezy-crabs-camp.md * Update breezy-crabs-camp.md * WIP: copy button overlay * rm space * adds faker * update copy button interaction styling * downgrade faker * Update CanvasHeader.stories.tsx * fix typo in changeset * add proptypes * conditionally render resourceBadges wrapper * add dark mode styles * add bg color * Update CanvasHeader.stories.tsx * Update CanvasHeader.stories.tsx * improve focus styles commit df6a1e4 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jul 15 15:22:38 2024 -0700 Version Packages (#184) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit f5b9063 Author: Stephen Lee <[email protected]> Date: Fri Jul 12 13:43:09 2024 -0700 Fix naming of lg-private packages (#183) * Fix lg-private packages naming * Changeset commit a068930 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jul 11 13:15:56 2024 -0700 Version Packages (#177) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 2abf344 Author: Shaneeza <[email protected]> Date: Wed Jul 3 12:33:13 2024 -0400 LG-4058: add badges to `CanvasHeader` (#176) * add badges to canvasheader * changeset * ids * one line example * one line again * use color tokens * forgot to save * bump dependencies * add storybook dep * break out stories * remove multiple action story * feedback commit ee1af09 Author: Adam Thompson <[email protected]> Date: Tue Apr 9 16:48:41 2024 -0400 Updates manual publishing docs (#125) * Update .npmrc * merge npmrc * merge npmrc * update registry * Update README.md * typo * Update .npmrc commit 338ba02 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Apr 9 13:24:37 2024 -0400 Version Packages (#123) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit de15015 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Mar 26 12:13:21 2024 -0400 Version Packages (#102) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 141bfd0 Author: Adam Thompson <[email protected]> Date: Wed Mar 6 14:41:54 2024 -0500 Bump `@leafygreen-ui` & `@lg-tools` dependencies (#115) * bump lg-tools deps * bumps cloud nav deps * bump canvas header deps * Create loud-melons-remain.md * Update shared-pr.yml * updates build cache key * Update package.json * chromatic needs build commit 6c33cd5 Author: Adam Thompson <[email protected]> Date: Wed Feb 28 17:20:03 2024 -0500 Use `chromaui/action` (#113) * bump react types resolutions * fix resolutions * uses chromaui/action * expect prop types error * bump chromatic * mv chromatic job * Update yarn.lock commit 9dabc6a Author: Shaneeza <[email protected]> Date: Mon Feb 26 14:25:36 2024 -0500 bump changeset (#110) commit e1e1437 Author: Shaneeza <[email protected]> Date: Mon Feb 26 13:20:18 2024 -0500 LG-3949: canvasHeader component (#106) * WIP * div * wip * fix copy icon underline * add opacity * hover and focus styles * add copy func * add todo test * small tweaks * min-height * storybook * remove comments * story link * wip adding tests * remove mock stuff * resource tests * more resource tests * tests * remove backLink component * clean up * show copy icon with tooltip * some fixes * lint * readme * change package name * clean up * changeset * lint * testing * adressing brooke comments * sandy feedback * add BackLink component * forgot to save * brooke feedback * update generated story * fix z-index issue * spacing between page title and resource name * spacing between page title and resource name again * add top and bottom margin * testing * remove some controls * testing * testing * update testid * remove z-index; no longer needed * bump typography * test * test --------- Co-authored-by: Adam Thompson <[email protected]> Squashed commit of the following: commit b1e22ce Merge: 84e889e ee58160 Author: Adam Thompson <[email protected]> Date: Thu Nov 20 16:17:28 2025 -0500 Merge branch 'main' into at/canvas-header commit 84e889e Author: Adam Thompson <[email protected]> Date: Thu Nov 20 15:27:47 2025 -0500 Update .changeset/canvas-header.md Co-authored-by: Stephen Lee <[email protected]> commit 01049b2 Author: Adam Michael Thompson <[email protected]> Date: Thu Nov 20 15:24:22 2025 -0500 Update tsconfig.json commit ee58160 Author: Nima Taheri <[email protected]> Date: Thu Nov 20 11:55:41 2025 -0800 CLOUDP-352308 Enhanced CLI options for robust linking (#3311) * feat: update CLI options for improved linking process * docs: add changelog * docs: apply review feedback * apply: review comments + docs update * apply: review comments (2) commit eb49bd0 Merge: d525c25 43810b4 Author: Adam Thompson <[email protected]> Date: Thu Nov 20 13:25:10 2025 -0500 Merge branch 'main' into at/canvas-header commit 43810b4 Author: Nima Taheri <[email protected]> Date: Wed Nov 19 15:30:29 2025 -0800 LG-5635 fix unexpected @emotion imports in umd bundle of icons (#3319) * feat: stricter post-build check on icon package * fix: not waiting for promises to finish commit d525c25 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:41:59 2025 -0500 fixes commit a35da52 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:30:04 2025 -0500 changeset commit b2c94c0 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:28:11 2025 -0500 update stories commit 4142151 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:27:59 2025 -0500 package json commit 3e09cf2 Merge: ec4fad8 e0d0b02 Author: Adam Michael Thompson <[email protected]> Date: Wed Nov 19 17:18:17 2025 -0500 Add 'packages/canvas-header/' from commit 'e0d0b0293e1981eefa8b8a4df9a37926532356b6' git-subtree-dir: packages/canvas-header git-subtree-mainline: ec4fad8 git-subtree-split: e0d0b02 commit ec4fad8 Author: Adam Rasheed <[email protected]> Date: Wed Nov 19 12:35:14 2025 -0800 [LG-5748] chore: Add Text and Border Color Variants (#3321) * [LG-5748] chore: Add Text and Border Color Variants * updated changset commit d816392 Author: Adam Thompson <[email protected]> Date: Wed Nov 19 14:44:05 2025 -0500 LG-5740 fix(LoadingIndicator) fixes spinner type references (#3315) * Update package.json * Create loading-spinner-types.md commit 55580b8 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 16:32:50 2025 -0500 [LG-2957] feat: GuideCue - Update Button Focus (#3277) * [LG-2957] feat: GuideCue - Update Button Focus * comment cleanup * udpated changelog, udpated test assertion commit d8485a9 Author: Adam Rasheed <[email protected]> Date: Mon Nov 17 14:16:13 2025 -0500 [LG-5666] MCP-UI App Scaffolding (#3280) * [LG-5666] MCP-UI App Scaffolding * Added component, sdk scaffolding, package json updates * cleanup * fixed linting * updated workspace * added tsconfig * updated build * r17 updates * updated turbo settings * added devDeps * rm sdk, changed directory structure, updated listdb styles * fix: r17 scripts (#3305) * update r17 scripts * filter apps from r17 build workflow * add mcpui to caches --------- Co-authored-by: Adam Thompson <[email protected]> commit c7d6e62 Author: Stephen Lee <[email protected]> Date: Fri Nov 14 07:14:00 2025 -0800 feat(popover): pass through popover enum types (#3302) * feat(combobox): export RenderMode enum from popover package * chore(combobox): changeset * feat(date-picker): export Align and Justify enums from popover package * chore(date-picker): changeset * feat(guide-cue): export BeaconAlign enum * chore(guide-cue): changeset * feat(menu): export Align, Justify, and RenderMode enums from popover package * chore(menu): changeset * feat(split-button): export RenderMode and make popover package dev dep * chore(split-button): changeset * refactor(split-button): consolidate menu imports * refactor(split-button): rename imported enums commit d7e989b Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Nov 13 23:42:07 2025 +0000 Version Packages (#3313) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit 999febf Author: Nima Taheri <[email protected]> Date: Thu Nov 13 15:01:26 2025 -0800 CLOUDP-352308 add logging for spawn processes in link tools (#3310) * feat: enable logging for spawn processes * docs: add changelog * refactor: as co-pilot suggested test: add unit test commit 587f14e Author: Stephen Lee <[email protected]> Date: Thu Nov 13 14:03:47 2025 -0800 fix(modal): add explicit margin auto to dialog element styles (#3312) * fix(modal): add explicit margin * chore(modal): changeset commit e0d0b02 Author: Adam Thompson <[email protected]> Date: Wed Jun 18 12:44:57 2025 -0400 PNPM + Storybook 8 (private) (#426) * pnpm import * Delete yarn.lock * workflows * yarn -> pnpm docs * workspace:^ * add missing global packages * @storybook/test * story ts fixes * Adds missing peers * rm lg.json * bump base lg * fix product icon builds * fix sb * bump peer deps * rm pnpm/action-setup@v4 * Revert "rm pnpm/action-setup@v4" This reverts commit 14198eb258e958ddaa0e480fee17cfddec5ce6fd. * Update pnpm-lock.yaml * apk * apk all * wget * restore pnpm * specific pnpm action * workspace * lint fix * tools @ latest * minor lint errors * tools build dev deps * typescript * tsconfig * package exports * ts fixes * Create rollup.config.mjs * lint * checkout main src * ts fixes * lint * isolated async tests * Update CloudNav.analytics.spec.tsx * skip mongonav tests * feature walls tests * Create rollup.config.mjs * lint fix * Update pr.yml * Update release.yml * cache/restore * chromatic + pnpm * update cache restore paths * cache save path * addon 0.5.2-next.0 * addon 0.5.2-next.2 commit 0d81bf1 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Mar 26 17:51:47 2025 +0000 Version Packages (#411) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 4445f18 Author: Shaneeza <[email protected]> Date: Tue Mar 25 16:06:42 2025 -0400 Update CanvasHeader live example for .design (#418) * update live example for .design * remove extra characters * changeset commit 12ba130 Author: Adam Thompson <[email protected]> Date: Thu Mar 13 16:14:08 2025 -0400 Canvas Header updates [LG-4938, LG-4958] (#406) * updates LiveExample * rm bg styles * fix icon spacing * fix "copied" tooltip alignment * Create canvas-header-bg.md * fix build * Update CanvasHeader.stories.tsx commit 7bb4d90 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Jan 21 13:28:01 2025 -0500 Version Packages (#343) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 82b1696 Author: Adam Thompson <[email protected]> Date: Thu Jan 9 15:55:54 2025 -0500 Updates Popover/Menu/Tooltip to TopLayer LG-4746 (#337) * bump other packages * major popover updates * bump provider * bump global provider * bump cli * rm popoverZIndex * Create forty-days-rest.md * Delete .eslintignore * update lg to latest major * Removes prop-types, and bump LG packages * lint * Update .eslintrc.js * update storybook @lg-tools/storybook-utils * lint commit f6a8aca Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Dec 2 18:51:14 2024 +0000 Version Packages (#298) * Version Packages * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Thompson <[email protected]> commit 580a4f0 Author: Adam Thompson <[email protected]> Date: Tue Nov 26 13:30:34 2024 -0500 Canvas header resource badges [LG-4675] (#299) * adds `resourceBadges` prop * Create breezy-crabs-camp.md * Update breezy-crabs-camp.md * WIP: copy button overlay * rm space * adds faker * update copy button interaction styling * downgrade faker * Update CanvasHeader.stories.tsx * fix typo in changeset * add proptypes * conditionally render resourceBadges wrapper * add dark mode styles * add bg color * Update CanvasHeader.stories.tsx * Update CanvasHeader.stories.tsx * improve focus styles commit df6a1e4 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jul 15 15:22:38 2024 -0700 Version Packages (#184) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit f5b9063 Author: Stephen Lee <[email protected]> Date: Fri Jul 12 13:43:09 2024 -0700 Fix naming of lg-private packages (#183) * Fix lg-private packages naming * Changeset commit a068930 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jul 11 13:15:56 2024 -0700 Version Packages (#177) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 2abf344 Author: Shaneeza <[email protected]> Date: Wed Jul 3 12:33:13 2024 -0400 LG-4058: add badges to `CanvasHeader` (#176) * add badges to canvasheader * changeset * ids * one line example * one line again * use color tokens * forgot to save * bump dependencies * add storybook dep * break out stories * remove multiple action story * feedback commit ee1af09 Author: Adam Thompson <[email protected]> Date: Tue Apr 9 16:48:41 2024 -0400 Updates manual publishing docs (#125) * Update .npmrc * merge npmrc * merge npmrc * update registry * Update README.md * typo * Update .npmrc commit 338ba02 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Apr 9 13:24:37 2024 -0400 Version Packages (#123) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit de15015 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Mar 26 12:13:21 2024 -0400 Version Packages (#102) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 141bfd0 Author: Adam Thompson <[email protected]> Date: Wed Mar 6 14:41:54 2024 -0500 Bump `@leafygreen-ui` & `@lg-tools` dependencies (#115) * bump lg-tools deps * bumps cloud nav deps * bump canvas header deps * Create loud-melons-remain.md * Update shared-pr.yml * updates build cache key * Update package.json * chromatic needs build commit 6c33cd5 Author: Adam Thompson <[email protected]> Date: Wed Feb 28 17:20:03 2024 -0500 Use `chromaui/action` (#113) * bump react types resolutions * fix resolutions * uses chromaui/action * expect prop types error * bump chromatic * mv chromatic job * Update yarn.lock commit 9dabc6a Author: Shaneeza <[email protected]> Date: Mon Feb 26 14:25:36 2024 -0500 bump changeset (#110) commit e1e1437 Author: Shaneeza <[email protected]> Date: Mon Feb 26 13:20:18 2024 -0500 LG-3949: canvasHeader component (#106) * WIP * div * wip * fix copy icon underline * add opacity * hover and focus styles * add copy func * add todo test * small tweaks * min-height * storybook * remove comments * story link * wip adding tests * remove mock stuff * resource tests * more resource tests * tests * remove backLink component * clean up * show copy icon with tooltip * some fixes * lint * readme * change package name * clean up * changeset * lint * testing * adressing brooke comments * sandy feedback * add BackLink component * forgot to save * brooke feedback * update generated story * fix z-index issue * spacing between page title and resource name * spacing between page title and resource name again * add top and bottom margin * testing * remove some controls * testing * testing * update testid * remove z-index; no longer needed * bump typography * test * test --------- Co-authored-by: Adam Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chain of upstream PRs as of 2025-11-12
PR CLOUDP-352308 add logging for spawn processes in link tools #3310:
main←cloudp-352308-spawn-loggedcloudp-352308-spawn-logged←cloudp-352308-robust-link-flags🎫 Ticket
CLOUDP-352308
📝 Description
This PR introduces new CLI flags to improve the flexibility of the linking process.
✨ New Features
--no-parallelflag: Run link commands sequentially instead of parallel execution. Useful for debugging or when parallel linking fails due to race conditions.--launch-envflag: Specify custom environment variables for spawned processes. This helps work around environment pollution from version managers (likeasdfornvm) or script runners (likepnpm). Recommended usage:--launch-env="$(env)"to use your original shell environment.🧪 Documentation and Testing
DEVELOPER.mdwith troubleshooting guidancepnpm changesetand documented my changes--no-parallelflag--launch-envflag