Skip to content

DOCSP-50295 Move AWS STS copy #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025

Conversation

jordan-smith721
Copy link
Collaborator

@jordan-smith721 jordan-smith721 commented May 23, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-50295

Staging Links

  • security/authentication/aws-iam
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented May 23, 2025

    Deploy Preview for docs-node ready!

    Name Link
    🔨 Latest commit c55d747
    🔍 Latest deploy log https://app.netlify.com/projects/docs-node/deploys/6830a2dd109ded0008aa11ed
    😎 Deploy Preview https://deploy-preview-1155--docs-node.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    Copy link
    Collaborator

    @mcmorisi mcmorisi left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM, thanks for grabbing this!

    `Regional Endpoints <https://docs.aws.amazon.com/general/latest/gr/rande.html#regional-endpoints>`__
    section of the AWS Service Endpoints reference in the AWS documentation.

    .. warning:: Consult your SDK's Documentation for Setting an AWS Region
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I think we should remove or amend this warning: right now it's confusing because the driver uses aws-sdk/credential-providers; the warning is relevant to users who may not be using the node driver or who reuse their configuration elsewhere in their application

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Removed!

    @jordan-smith721 jordan-smith721 requested a review from dariakp May 23, 2025 16:34
    @jordan-smith721 jordan-smith721 merged commit 8709448 into mongodb:master May 27, 2025
    6 checks passed
    @jordan-smith721 jordan-smith721 deleted the move-aws-sts-copy branch May 27, 2025 15:17
    jordan-smith721 added a commit that referenced this pull request May 27, 2025
    (cherry picked from commit 8709448)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants