-
Notifications
You must be signed in to change notification settings - Fork 51
DOCSP-50295 Move AWS STS copy #1155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-50295 Move AWS STS copy #1155
Conversation
✅ Deploy Preview for docs-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for grabbing this!
`Regional Endpoints <https://docs.aws.amazon.com/general/latest/gr/rande.html#regional-endpoints>`__ | ||
section of the AWS Service Endpoints reference in the AWS documentation. | ||
|
||
.. warning:: Consult your SDK's Documentation for Setting an AWS Region |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove or amend this warning: right now it's confusing because the driver uses aws-sdk/credential-providers; the warning is relevant to users who may not be using the node driver or who reuse their configuration elsewhere in their application
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed!
(cherry picked from commit 8709448)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-50295
Staging Links
Self-Review Checklist