Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-48590-connect-via-atlas-cli #110

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

amalhotra-mdb
Copy link
Contributor

@amalhotra-mdb amalhotra-mdb commented Apr 3, 2025

DESCRIPTION

Add new "Connect with Atlas CLI" section in MongoDB for VS Code Connect page.

STAGING

https://deploy-preview-110--docs-mongodb-vscode.netlify.app/connect/#create-a-connection

JIRA

https://jira.mongodb.org/browse/DOCSP-48950

BUILD LOG

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for docs-mongodb-vscode ready!

Name Link
🔨 Latest commit 676a1ed
🔍 Latest deploy log https://app.netlify.com/sites/docs-mongodb-vscode/deploys/67f0380c62908d000823c7f7
😎 Deploy Preview https://deploy-preview-110--docs-mongodb-vscode.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 32 (🔴 down 12 from production)
Accessibility: 91 (no change from production)
Best Practices: 75 (no change from production)
SEO: 75 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
Copy link
Contributor

@jmd-mongo jmd-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates, @amalhotra-mdb! I've left a question and a recommendation for your consideration.

Thanks!
Joe

@@ -1,5 +1,5 @@
---
title: "In |vscode-short|, click the :guilabel:`MongoDB` icon in the :guilabel:`Activity Bar`"
title: "In |vscode-short|, click the :guilabel:`MongoDB` icon in the :guilabel:`Activity Bar`."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question]

Should we remove the double quotes to be more consistent with the other titles?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this, I think we should!

@@ -0,0 +1,57 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is a new content, I recommend using .. procedure:: and .. step:: directives in this procedure.

Spitballing:

.. procedure::
   :style: normal

   .. step:: Connect from the Atlas CLI. 
   
       In your terminal, run ...

@amalhotra-mdb amalhotra-mdb requested a review from jmd-mongo April 4, 2025 19:54
@amalhotra-mdb
Copy link
Contributor Author

Thanks for your help on this, @jmd-mongo ! Could you take another look at the changes, whenever you get a chance?

Copy link
Contributor

@jmd-mongo jmd-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these updates, @amalhotra-mdb! This one LGTM.

Thanks,
Joe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants