-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-48590-connect-via-atlas-cli #110
base: master
Are you sure you want to change the base?
DOCSP-48590-connect-via-atlas-cli #110
Conversation
✅ Deploy Preview for docs-mongodb-vscode ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these updates, @amalhotra-mdb! I've left a question and a recommendation for your consideration.
Thanks!
Joe
@@ -1,5 +1,5 @@ | |||
--- | |||
title: "In |vscode-short|, click the :guilabel:`MongoDB` icon in the :guilabel:`Activity Bar`" | |||
title: "In |vscode-short|, click the :guilabel:`MongoDB` icon in the :guilabel:`Activity Bar`." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[question]
Should we remove the double quotes to be more consistent with the other titles?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing this, I think we should!
@@ -0,0 +1,57 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this is a new content, I recommend using .. procedure::
and .. step::
directives in this procedure.
Spitballing:
.. procedure::
:style: normal
.. step:: Connect from the Atlas CLI.
In your terminal, run ...
Thanks for your help on this, @jmd-mongo ! Could you take another look at the changes, whenever you get a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these updates, @amalhotra-mdb! This one LGTM.
Thanks,
Joe
DESCRIPTION
Add new "Connect with Atlas CLI" section in MongoDB for VS Code Connect page.
STAGING
https://deploy-preview-110--docs-mongodb-vscode.netlify.app/connect/#create-a-connection
JIRA
https://jira.mongodb.org/browse/DOCSP-48950
BUILD LOG
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?