Skip to content

[Kotlin Sync] Support naming strategy for bson-kotlinx #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 3, 2025

Conversation

rachel-mack
Copy link
Collaborator

@rachel-mack rachel-mack commented Apr 2, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46215

Staging Links

  • data-formats/serialization
  • whats-new
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    @rachel-mack rachel-mack requested a review from a team as a code owner April 2, 2025 14:14
    @rachel-mack rachel-mack requested review from rozza and removed request for a team April 2, 2025 14:14
    Copy link

    netlify bot commented Apr 2, 2025

    Deploy Preview for docs-kotlin-sync ready!

    Name Link
    🔨 Latest commit 129f46a
    🔍 Latest deploy log https://app.netlify.com/sites/docs-kotlin-sync/deploys/67eea0bed2787d0008ee1a93
    😎 Deploy Preview https://deploy-preview-90--docs-kotlin-sync.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @rachel-mack rachel-mack requested a review from rozza April 2, 2025 16:59
    @@ -29,6 +29,10 @@ What's New in 5.4
    The 5.4 driver release includes the following changes, fixes,
    and features:

    - Adds support for converting field names to snake case during serialization. To
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: consider bumping this out into a "Serialization Features" subheading

    @rachel-mack rachel-mack requested a review from rustagir April 3, 2025 14:53
    Copy link
    Collaborator

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm w/ 2 small suggestions!

    The following example shows how to create and register a custom codec
    to convert data class field names into snake case by setting the
    ``bsonNamingStrategy`` parameter in a codec:

    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: remove extra line

    Comment on lines +32 to +34
    - Adds ``BsonConfiguration`` support for bson-kotlinx snake case conversion
    during serialization. To learn more, see the
    :ref:`kotlin-sync-serialization-snake-case-eg` on the Serialization page.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    - Adds ``BsonConfiguration`` support for bson-kotlinx snake case conversion
    during serialization. To learn more, see the
    :ref:`kotlin-sync-serialization-snake-case-eg` on the Serialization page.
    - Adds ``BsonConfiguration`` support in the ``bson-kotlinx`` package for snake case
    conversion during serialization. To learn more, see the
    :ref:`kotlin-sync-serialization-snake-case-eg` section in the Serialization page.

    @rachel-mack rachel-mack merged commit 84aa7bb into mongodb:master Apr 3, 2025
    6 checks passed
    rustagir pushed a commit that referenced this pull request Apr 3, 2025
    * snake case example
    
    * move release note
    
    * dependency name
    
    * RR feedback
    
    * update release note
    
    (cherry picked from commit 84aa7bb)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants