Skip to content

DOCSP-49067: Cursors #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 16, 2025
Merged

DOCSP-49067: Cursors #584

merged 6 commits into from
Apr 16, 2025

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Apr 9, 2025 •
edited by github-actions bot
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-49067

Staging Links

  • crud/query/cursors

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    @netlify Netlify
    Copy link

    netlify bot commented Apr 9, 2025 •
    edited
    Loading

    ✅ Deploy Preview for docs-csharp ready!

    Name Link
    🔨 Latest commit 43f9d81
    🔍 Latest deploy log https://app.netlify.com/sites/docs-csharp/deploys/67ffaad2fdc12500080aaaf6
    😎 Deploy Preview https://deploy-preview-584--docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @rustagir rustagir self-requested a review April 10, 2025 14:01
    rustagir
    rustagir requested changes Apr 10, 2025
    View reviewed changes
    Copy link
    Collaborator

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    overall looks good just added a few comments to support completeness

    source/crud/query/cursors.txt
    :start-after: start-cursor-iterate
    :end-before: end-cursor-iterate
    :language: csharp
    :dedent:
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: for all examples, consider showing some output to demonstrate the differences in how results look when accessing iteratively vs from a list, etc

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Pretty sure there's no difference in output between cursors and lists, it's just differences in program flow. With the current filters this would just be printing Starbucks/Dunkin' Donuts a bunch. I'm not sure including output would help illustrate any functionality differences. Should I tweak the filters so it at least prints different restaurant names?

    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I think that showing a print statement in the code example might lead users to expect an output block, but it's up to you.

    @mcmorisi mcmorisi requested a review from rustagir April 10, 2025 14:49
    rustagir
    rustagir approved these changes Apr 10, 2025
    View reviewed changes
    Copy link
    Collaborator

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    looks good!

    @mcmorisi mcmorisi requested review from a team, JamesKovacs and papafe and removed request for a team and JamesKovacs April 10, 2025 17:11
    papafe
    papafe approved these changes Apr 15, 2025
    View reviewed changes
    Copy link

    @papafe papafe left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @mcmorisi mcmorisi merged commit dae52bf into mongodb:docsp-45382-comp-cvg Apr 16, 2025
    2 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-49067-cursors branch April 16, 2025 13:04
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @papafe papafe papafe approved these changes

    @rustagir rustagir rustagir approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @mcmorisi @papafe @rustagir