DOCSP-45739 Adds nonce in Auth Req to OIDC connection settings #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-compass ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jmd-mongo
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Thanks for this addition, @jwilson-mdb! This one LGTM mod a nit.
Thanks,
Joe
| request to prevent replay attacks. Enabled by default. | ||
|
|
||
| The nonce is an important security component. This setting should | ||
| only be disabled if it is not supported by your OIDC provider. |
There was a problem hiding this comment.
[nit]
Consider a stronger phrasing. Spitballing: "Only disable this setting if it is not supported by your OIDC provider."
There was a problem hiding this comment.
Thanks Joe, I think shortening it up and removing should improves it quite a bit.
I'll update this to incorporate your suggestion!
nirinchev
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Updates OIDC connection settings to include the new checkbox
Send a nonce in the Auth Code RequestNote - the description here is based on the UI description in the eng PR.
STAGING
https://deploy-preview-700--docs-compass.netlify.app/connect/advanced-connection-options/authentication-connection/#oidc
JIRA
https://jira.mongodb.org/browse/DOCSP-45739
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?