Rename ArrayField.size to max_size #273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
force-pushed
the
rename-array-field-size
branch
from
75ac89a to
5c41658
Compare
WaVEV
reviewed
Mar 23, 2025
timgraham
force-pushed
the
rename-array-field-size
branch
from
5c41658 to
a345548
Compare
timgraham
force-pushed
the
rename-array-field-size
branch
from
a345548 to
1c82dbd
Compare
If in the future we want to add min size / min length, and maybe we have to refactor and breaks some compatibilities. So, how likely is to add min length in the future given the form supports it?. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vector search indexes need to be a fixed size, so
sizewill be re-added to represent that (#264).I didn't rename
SplitArrayWidget.size, thinking maybe it makes sense to add a separate kwarg likefixed_size=True, but I'm still thinking about the best solution.