Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(participant): add disambiguation examples to answer MongoDB queries in Copilot #911
feat(participant): add disambiguation examples to answer MongoDB queries in Copilot #911
Changes from all commits
53d3a1f
bb2802d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more complicated so doesn't need to be included necessarily but I often ask about a query like "How do I find all documents with name "Bob" in my MongoDB collection?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if that wiill be frowned upon, but we could consider dropping the MongoDB there -
How do I find all documents in my collection
- the terms document and collection are quite often associated with MongoDB and if they have the extension installed, it's very likely that they're interfacing on some level with a mongodb database.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must say GitHub Copilot has been doing this automatic inference thing with other things and it always ends inferring something I did not want it to (I was looking to disable it completely) so my worry is that it'll be too permissive with the word "documents" in general. We can try this and test it out though, collections + documents is reasonable if it stays strict to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also might be a more common use case without the "How to" prefix, e.g.
find all documents with name "bob" in my "test" collection
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with y'all, I added "find all documents in my collection" example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add some examlers about schema?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some more examples about schema!