chore(logs): add additional logging around auth updates COMPASS-9366 #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
commented
Jun 5, 2025
| prefs: { | ||
| 'profile.password_manager_enabled': false, | ||
| credentials_enable_service: false, | ||
| }, |
There was a problem hiding this comment.
Pulled this in from the node update pr. This prevents the popups about passwords that get in the way of local testing.
addaleax
approved these changes
Jun 6, 2025
addaleax
reviewed
Jun 6, 2025
| authStateId: state.id, | ||
| isCurrentAuthAttemptSet: !!state.currentAuthAttempt, | ||
| tokenSetId: params.refreshToken, | ||
| }); |
There was a problem hiding this comment.
Fwiw I still think this would be useful:
Log when we enter/leave requestToken(), and in particular log whether state.currentAuthAttempt is set or not. Include the UserOIDCAuthState id as well, and the values of the known fields of serverOIDCMetadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-9366
This pr adds additional logs around our auth flow as well as adds an id to our auth state object. This id should be useful for following an auth flow, and possibly showing why outdated auth calls are being attempted (more context in the ticket).