Skip to content

Conversation

@himanshusinghs
Copy link
Collaborator

@himanshusinghs himanshusinghs commented Nov 7, 2025

Proposed changes

Proposes the following:

  1. Modifies the description of createIndex tool's index definition object. We will mention vectorSearch only when the feature is enabled. Additionally adds additional tests for the metadata - 198b36e
  2. Adds validation for document field embeddings when the index quantization is set to none - 5cd2e51
  3. Adds a warning when vector search is not correctly configured - fbb3d0f

Checklist

@coveralls
Copy link
Collaborator

coveralls commented Nov 7, 2025

Pull Request Test Coverage Report for Build 19171504420

Details

  • 32 of 38 (84.21%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 80.106%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/common/config.ts 11 17 64.71%
Files with Coverage Reduction New Missed Lines %
src/common/search/vectorSearchEmbeddingsManager.ts 1 83.89%
Totals Coverage Status
Change from base Build 19133495784: -0.05%
Covered Lines: 6503
Relevant Lines: 8004

💛 - Coveralls

@himanshusinghs himanshusinghs marked this pull request as ready for review November 7, 2025 14:26
@himanshusinghs himanshusinghs requested a review from a team as a code owner November 7, 2025 14:26
Copilot AI review requested due to automatic review settings November 7, 2025 14:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances vector search configuration validation and improves tool metadata clarity. The main purpose is to ensure proper vector search setup and provide better user feedback when configurations are incorrect.

Key changes:

  • Adds validation for embeddings when quantization is set to "none"
  • Introduces warnings when vector search feature and embeddings provider configurations are mismatched
  • Updates warning message formatting for better readability

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/common/search/vectorSearchEmbeddingsManager.ts Implements validation logic for "none" quantization to ensure embeddings are proper numeric arrays with correct dimensions
src/common/config.ts Adds configuration validation warnings for vector search/embeddings provider mismatches and updates warning message formatting
src/tools/mongodb/create/createIndex.ts Makes vectorSearch reference conditional in tool description based on feature availability
tests/unit/common/search/vectorSearchEmbeddingsManager.test.ts Extends test coverage to validate "none" quantization handling across multiple scenarios
tests/unit/common/config.test.ts Updates test expectations to match new warning message format
tests/integration/tools/mongodb/create/createIndex.test.ts Adds metadata validation and updates expected description text
tests/integration/tools/mongodb/create/insertMany.test.ts Adds metadata validation test for insert-many tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants