chore(typescript): enable erasableSyntaxOnly for the whole repo; add temporary ts-expect-errors to enums

configs/testing-library-compass/src/index.tsx

@@ -127,8 +127,10 @@ export class MockDataService
       | 'instance'
     >
 {
-  constructor(private connectionOptions: ConnectionInfo['connectionOptions']) {
+  private connectionOptions: ConnectionInfo['connectionOptions'];
+  constructor(connectionOptions: ConnectionInfo['connectionOptions']) {
     super();
+    this.connectionOptions = connectionOptions;
     this.setMaxListeners(0);
   }
   getConnectionString() {

configs/tsconfig-compass/tsconfig.common.json

@@ -3,6 +3,7 @@
   "compilerOptions": {
     "removeComments": false,
     "moduleResolution": "node16",
-    "module": "node16"
+    "module": "node16",
+    "erasableSyntaxOnly": true
   }
 }

configs/tsconfig-compass/tsconfig.react.json

@@ -3,6 +3,7 @@
   "compilerOptions": {
     "removeComments": false,
     "moduleResolution": "node16",
-    "module": "node16"
+    "module": "node16",
+    "erasableSyntaxOnly": true
   }
 }

packages/atlas-service/src/atlas-service.ts

@@ -53,13 +53,24 @@ function getAutomationAgentClusterId(
 }
 
 export class AtlasService {
+  private readonly authService: AtlasAuthService;
+  private readonly preferences: PreferencesAccess;
+  private readonly logger: Logger;
+  private readonly options?: AtlasServiceOptions;
+  private readonly defaultConfigOverride?: AtlasServiceConfig;
   constructor(
-    private readonly authService: AtlasAuthService,
-    private readonly preferences: PreferencesAccess,
-    private readonly logger: Logger,
-    private readonly options?: AtlasServiceOptions,
-    private readonly defaultConfigOverride?: AtlasServiceConfig
-  ) {}
+    authService: AtlasAuthService,
+    preferences: PreferencesAccess,
+    logger: Logger,
+    options?: AtlasServiceOptions,
+    defaultConfigOverride?: AtlasServiceConfig
+  ) {
+    this.authService = authService;
+    this.preferences = preferences;
+    this.logger = logger;
+    this.options = options;
+    this.defaultConfigOverride = defaultConfigOverride;
+  }
   // Config value is dynamic to make sure that process.env overrides are taken
   // into account in runtime
   get config(): AtlasServiceConfig {

packages/atlas-service/src/store/atlas-signin-reducer.ts

@@ -35,6 +35,7 @@ export type AtlasSignInThunkAction<
   A extends AnyAction = AnyAction
 > = ThunkAction<R, AtlasSignInState, { atlasAuthService: AtlasAuthService }, A>;
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export const enum AtlasSignInActions {
   RestoringStart = 'atlas-service/atlas-signin/StartRestoring',
   RestoringFailed = 'atlas-service/atlas-signin/RestoringFailed',

packages/compass-aggregations/src/modules/aggregation.ts

@@ -41,6 +41,7 @@ export const WriteOperation = {
   Overwrite: 'overwriting',
 } as const;
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum ActionTypes {
   RunAggregation = 'compass-aggeregations/runAggregation',
   AggregationStarted = 'compass-aggregations/aggregationStarted',

packages/compass-aggregations/src/modules/auto-preview.ts

@@ -7,6 +7,7 @@ import type { RestorePipelineAction } from './saved-pipeline';
 import { RESTORE_PIPELINE } from './saved-pipeline';
 import { isAction } from '../utils/is-action';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum ActionTypes {
   AutoPreviewToggled = 'compass-aggregations/autoPreviewToggled',
 }

packages/compass-aggregations/src/modules/collection-stats.ts

@@ -20,6 +20,7 @@ export function pickCollectionStats(collection: Collection): CollectionStats {
   };
 }
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 enum CollectionStatsActions {
   CollectionStatsFetched = 'compass-aggregations/collection-stats/CollectionStatsFetched',
 }

packages/compass-aggregations/src/modules/collections-fields.ts

@@ -12,6 +12,7 @@ export type CollectionInfo = Pick<Collection, 'name' | 'type'>;
 
 type CollectionType = CollectionInfo['type'];
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum ActionTypes {
   CollectionsFetch = 'compass-aggregations/collectionsFetched',
   CollectionFieldsFetched = 'compass-aggregations/collectionFieldsFetched',

packages/compass-aggregations/src/modules/count-documents.ts

@@ -10,6 +10,7 @@ import { ActionTypes as ConfirmNewPipelineActions } from './is-new-pipeline-conf
 import { getPipelineFromBuilderState } from './pipeline-builder/builder-helpers';
 import { isAction } from '../utils/is-action';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum ActionTypes {
   CountStarted = 'compass-aggregations/countStarted',
   CountFinished = 'compass-aggregations/countFinished',

packages/compass-aggregations/src/modules/create-view/index.ts

@@ -26,6 +26,7 @@ export const INITIAL_STATE: CreateViewState = {
   pipeline: [],
 };
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 enum CreateViewActionTypes {
   Open = 'aggregations/create-view/Open',
   Close = 'aggregations/create-view/Close',

packages/compass-aggregations/src/modules/focus-mode.ts

@@ -3,6 +3,7 @@ import type { PipelineBuilderThunkAction } from '.';
 import { isAction } from '../utils/is-action';
 import { addStage, pipelineFromStore } from './pipeline-builder/stage-editor';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 enum ActionTypes {
   FocusModeEnabled = 'compass-aggregations/focusModeEnabled',
   FocusModeDisabled = 'compass-aggregations/focusModeDisabled',

packages/compass-aggregations/src/modules/input-documents.ts

@@ -5,6 +5,7 @@ import type { AnyAction } from 'redux';
 import { isAction } from '../utils/is-action';
 import { DEFAULT_MAX_TIME_MS } from '../constants';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum ActionTypes {
   CollapseToggled = 'aggregations/input-documents/CollapseToggled',
   DocumentsFetchStarted = 'aggregations/input-documents/DocumentsFetchStarted',

packages/compass-aggregations/src/modules/is-new-pipeline-confirm.ts

@@ -5,6 +5,7 @@ import type Stage from './pipeline-builder/stage';
 import type { Document } from 'bson';
 import type { PipelineParserError } from './pipeline-builder/pipeline-parser/utils';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum ActionTypes {
   NewPipelineConfirmed = 'compass-aggregations/is-new-pipeline-confirm/newPipelineConfirmed',
 }

packages/compass-aggregations/src/modules/pipeline-builder/pipeline-ai.ts

@@ -43,6 +43,7 @@ export const initialState: AIPipelineState = {
   isAggregationGeneratedFromQuery: false,
 };
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export const enum AIPipelineActionTypes {
   AIPipelineStarted = 'compass-aggregations/pipeline-builder/pipeline-ai/AIPipelineStarted',
   AIPipelineCancelled = 'compass-aggregations/pipeline-builder/pipeline-ai/AIPipelineCancelled',

packages/compass-aggregations/src/modules/pipeline-builder/pipeline-mode.ts

@@ -19,6 +19,7 @@ import type {
 
 export type PipelineMode = 'builder-ui' | 'as-text';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum ActionTypes {
   PipelineModeToggled = 'compass-aggregations/pipelineModeToggled',
 }

packages/compass-aggregations/src/modules/pipeline-builder/pipeline-parser/stage-parser.ts

@@ -53,6 +53,7 @@ function getKeyName(node: t.ObjectProperty['key']): string | null {
     : null;
 }
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export const enum StageAssertionErrorCodes {
   InvalidStage,
   NotObjectExpression,

packages/compass-aggregations/src/modules/pipeline-builder/pipeline-parser/utils.ts

@@ -11,8 +11,12 @@ type ErrorLoc = {
 };
 
 export class PipelineParserError extends SyntaxError {
-  constructor(message: string, public loc?: ErrorLoc, public code?: number) {
+  loc?: ErrorLoc;
+  code?: number;
+  constructor(message: string, loc?: ErrorLoc, code?: number) {
     super(message);
+    this.loc = loc;
+    this.code = code;
   }
 }
 

packages/compass-aggregations/src/modules/pipeline-builder/pipeline-preview-manager.ts

@@ -76,10 +76,12 @@ export function createPreviewAggregation(
 export class PipelinePreviewManager {
   private queue = new Map<number, AbortController>();
   private lastPipeline = new Map<number, Document[]>();
-  constructor(
-    private dataService: DataService,
-    private preferences: PreferencesAccess
-  ) {}
+  private dataService: DataService;
+  private preferences: PreferencesAccess;
+  constructor(dataService: DataService, preferences: PreferencesAccess) {
+    this.dataService = dataService;
+    this.preferences = preferences;
+  }
 
   /**
    * Request aggregation results with a default debounce

packages/compass-aggregations/src/modules/pipeline-builder/stage-editor.ts

@@ -35,6 +35,7 @@ import type {
   PipelineGeneratedFromQueryAction,
 } from './pipeline-ai';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export const enum StageEditorActionTypes {
   StagePreviewFetch = 'compass-aggregations/pipeline-builder/stage-editor/StagePreviewFetch',
   StagePreviewFetchSkipped = 'compass-aggregations/pipeline-builder/stage-editor/StagePreviewFetchSkipped',

packages/compass-aggregations/src/modules/pipeline-builder/text-editor-output-stage.ts

@@ -20,6 +20,7 @@ import type {
 } from './pipeline-ai';
 import { getDestinationNamespaceFromStage } from '../../utils/stage';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 const enum OutputStageActionTypes {
   FetchStarted = 'compass-aggregations/pipeline-builder/text-editor-output-stage/FetchStarted',
   FetchSucceded = 'compass-aggregations/pipeline-builder/text-editor-output-stage/FetchSucceded',

packages/compass-aggregations/src/modules/pipeline-builder/text-editor-pipeline.ts

@@ -24,6 +24,7 @@ import type {
   PipelineGeneratedFromQueryAction,
 } from './pipeline-ai';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export const enum EditorActionTypes {
   EditorPreviewFetch = 'compass-aggregations/pipeline-builder/text-editor-pipeline/TextEditorPreviewFetch',
   EditorPreviewFetchSkipped = 'compass-aggregations/pipeline-builder/text-editor-pipeline/EditorPreviewFetchSkipped',

packages/compass-aggregations/src/modules/search-indexes.ts

@@ -3,6 +3,7 @@ import type { PipelineBuilderThunkAction } from '.';
 import type { SearchIndex } from 'mongodb-data-service';
 import { isAction } from '../utils/is-action';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 enum SearchIndexesStatuses {
   INITIAL = 'INITIAL',
   LOADING = 'LOADING',
@@ -12,6 +13,7 @@ enum SearchIndexesStatuses {
 
 export type SearchIndexesStatus = keyof typeof SearchIndexesStatuses;
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum ActionTypes {
   FetchIndexesStarted = 'compass-aggregations/search-indexes/FetchIndexesStarted',
   FetchIndexesFinished = 'compass-aggregations/search-indexes/FetchIndexesFinished',

packages/compass-aggregations/src/modules/side-panel.ts

@@ -3,6 +3,7 @@ import { type PipelineBuilderThunkAction } from '.';
 import { getPipelineFromBuilderState } from './pipeline-builder/builder-helpers';
 import type { AnyAction } from 'redux';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 enum ActionTypes {
   SidePanelToggled = 'compass-aggregations/sidePanelToggled',
 }

packages/compass-aggregations/src/modules/workspace.ts

@@ -12,6 +12,7 @@ import { isAction } from '../utils/is-action';
 
 export type Workspace = 'builder' | 'results';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum ActionTypes {
   WorkspaceChanged = 'compass-aggregations/workspaceChanged',
 }

packages/compass-collection/src/components/mock-data-generator-modal/types.ts

@@ -2,6 +2,7 @@ import type { MockDataSchemaResponse } from '@mongodb-js/compass-generative-ai';
 import type { FakerArg } from './script-generation-utils';
 import type { MongoDBFieldType } from '../../schema-analysis-types';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum MockDataGeneratorStep {
   SCHEMA_CONFIRMATION = 'SCHEMA_CONFIRMATION',
   SCHEMA_EDITOR = 'SCHEMA_EDITOR',
@@ -49,6 +50,7 @@ export interface FakerFieldMapping {
 
 export type FakerSchema = Record<string, FakerFieldMapping>;
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum DataGenerationStep {
   INSTALL_FAKERJS = 'install fakerjs',
   CREATE_JS_FILE = 'create js file',

packages/compass-collection/src/modules/collection-tab.ts

@@ -131,6 +131,7 @@ export type CollectionState = {
   fakerSchemaGeneration: MockDataGeneratorState;
 };
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum CollectionActions {
   CollectionMetadataFetched = 'compass-collection/CollectionMetadataFetched',
   SchemaAnalysisStarted = 'compass-collection/SchemaAnalysisStarted',

packages/compass-components/src/components/guide-cue/guide-cue-service.ts

@@ -37,9 +37,11 @@ export class GuideCueService extends EventTarget {
 
   private _activeGroupId: GroupName | null = null;
   private _activeCue: Cue | null = null;
+  private readonly _storage: GuideCueStorage;
 
-  constructor(private readonly _storage: GuideCueStorage) {
+  constructor(_storage: GuideCueStorage) {
     super();
+    this._storage = _storage;
   }
 
   addCue(cue: Omit<Cue, 'isVisited'>) {

packages/compass-components/src/components/guide-cue/guide-cue-storage.ts

@@ -8,13 +8,15 @@ export interface GuideCueStorage {
 }
 
 export class CompassGuideCueStorage implements GuideCueStorage {
+  private readonly storage: Pick<Storage, 'getItem' | 'setItem'>;
+  private readonly key: string;
   constructor(
-    private readonly storage: Pick<
-      Storage,
-      'getItem' | 'setItem'
-    > = globalThis.localStorage,
-    private readonly key: string = GUIDE_CUE_KEY
-  ) {}
+    storage: Pick<Storage, 'getItem' | 'setItem'> = globalThis.localStorage,
+    key: string = GUIDE_CUE_KEY
+  ) {
+    this.storage = storage;
+    this.key = key;
+  }
 
   get data(): GuideCueData {
     try {

packages/compass-components/src/components/resize-handle.tsx

@@ -2,6 +2,7 @@ import React, { useRef } from 'react';
 import { css, cx } from '@leafygreen-ui/emotion';
 import { palette } from '@leafygreen-ui/palette';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 enum ResizeDirection {
   TOP = 'TOP',
   RIGHT = 'RIGHT',

packages/compass-components/src/hooks/use-focus-hover.ts

@@ -7,6 +7,7 @@ import { mergeProps } from '@react-aria/utils';
 import type React from 'react';
 import { useEffect, useMemo, useRef, useState } from 'react';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum FocusState {
   NoFocus = 'NoFocus',
   FocusVisible = 'FocusVisible',

packages/compass-components/src/hooks/use-theme.tsx

@@ -3,6 +3,7 @@ import LeafyGreenProvider, {
   useDarkMode as useLeafyGreenDarkMode,
 } from '@leafygreen-ui/leafygreen-provider';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 enum Theme {
   Light = 'Light',
   Dark = 'Dark',

packages/compass-connections/src/connection-scoped-app-registry.ts

@@ -26,10 +26,15 @@ interface EventForwarder<T extends string> {
 export class ConnectionScopedAppRegistryImpl<T extends string>
   implements EventForwarder<T>
 {
+  private readonly appRegistryEmitter: AppRegistry['emit'];
+  private readonly connectionInfoRef: ConnectionInfoRef;
   constructor(
-    private readonly appRegistryEmitter: AppRegistry['emit'],
-    private readonly connectionInfoRef: ConnectionInfoRef
-  ) {}
+    appRegistryEmitter: AppRegistry['emit'],
+    connectionInfoRef: ConnectionInfoRef
+  ) {
+    this.appRegistryEmitter = appRegistryEmitter;
+    this.connectionInfoRef = connectionInfoRef;
+  }
 
   /**
    * @deprecated

packages/compass-connections/src/stores/connections-store-redux.ts

@@ -221,6 +221,7 @@ export type ConnectionsThunkAction<
   A extends AnyAction = AnyAction
 > = ThunkAction<R, State, ThunkExtraArg, A>;
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export const enum ActionTypes {
   // Actions related to getting connections from the persistent store (like disk
   // or cloud backend)

packages/compass-data-modeling/src/store/analysis-process.ts

@@ -31,6 +31,7 @@ export type AnalysisProcessState = {
   relationsInferred: number;
 };
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum AnalysisProcessActionTypes {
   ANALYZING_COLLECTIONS_START = 'data-modeling/analysis-stats/ANALYZING_COLLECTIONS_START',
   NAMESPACE_SAMPLE_FETCHED = 'data-modeling/analysis-stats/NAMESPACE_SAMPLE_FETCHED',

packages/compass-data-modeling/src/store/diagram.ts

@@ -65,6 +65,7 @@ export type DiagramState =
     })
   | null; // null when no diagram is currently open
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum DiagramActionTypes {
   OPEN_DIAGRAM = 'data-modeling/diagram/OPEN_DIAGRAM',
   DELETE_DIAGRAM = 'data-modeling/diagram/DELETE_DIAGRAM',

packages/compass-data-modeling/src/store/export-diagram.ts

@@ -16,6 +16,7 @@ export type ExportDiagramState = {
   exportFormat?: ExportDiagramFormat;
 };
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum ExportDiagramActionTypes {
   MODAL_OPENED = 'data-modeling/export-diagram/MODAL_OPENED',
   MODAL_CLOSED = 'data-modeling/export-diagram/MODAL_CLOSED',

packages/compass-data-modeling/src/store/generate-diagram-wizard.ts

@@ -26,6 +26,7 @@ export type GenerateDiagramWizardState = {
   error: Error | null;
 };
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum GenerateDiagramWizardActionTypes {
   CREATE_NEW_DIAGRAM = 'data-modeling/generate-diagram-wizard/CREATE_NEW_DIAGRAM',
   CANCEL_CREATE_NEW_DIAGRAM = 'data-modeling/generate-diagram-wizard/CANCEL_CREATE_NEW_DIAGRAM',