fix(eslint): fix await-thenable issues #7606
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
added
the
no-title-validation
nbbeeken
approved these changes
Nov 26, 2025
Comment on lines
+2221
to
+2224
| return ( | ||
| connectionStorage.delete?.({ id: connection.info.id }) ?? | ||
| Promise.resolve() | ||
| ); |
Collaborator
There was a problem hiding this comment.
(not asking for a change here) This is where I feel like an async (keyword) function is more appropriate than substituting a Promise.resolve. Plus return-await is a rule we employed in the driver because when you don't do that you remove functions from async stack traces.
return await connectionStorage.delete?.({ id: connection.info.id });
Collaborator
Author
There was a problem hiding this comment.
This does read better, let me see if switching to this will scream at me because I'm awaiting something that is maybe non-thenable (also makes sense in global-fixtures code I guess)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another straightforward one: in some cases we were awaiting non-promises, in most cases it wasn't a big deal, but in one particular case it was actually not doing what's expected as the promise was awaited before passing it to allSettled