-
Notifications
You must be signed in to change notification settings - Fork 231
chore(monorepo): bump required Node.js version to match electron environment #7339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Assigned |
Seems like this minor bump reveals an issue somewhere in our units:
Moving to draft for now to take a closer look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gribnoysup I'd actually check whether this also appears with the latest Node.js 22.x version, this sounds like a familiar bug in Node.js's ESM compatibility that has actually been fixed in more recent versions
Oh, interesting! I'll check, thanks for the pointer! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update .tool-versions
?
Same on latest 22, not exactly sure yet what's going on, but seems like in these Node.js versions some ts files are not passed through the ts-node anymore when mocha is running, looking a bit deeper |
Oufff, okay, seems like in Node.js 22.15 what was happening is:
In Node.js 22.18+ (maybe slightly earlier, I haven't tracked to exact version) |
Last time we were doing major electron upgrade, we forgot to bump required node version to match. This is just a minor one this time, so not that big of a deal, but it's helpful to keep it in sync to make sure that the tests are running in the same env that the app is running