feat(database-model,databases-collections,collection-model): hide system DBs COMPASS-9674 #7324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnjackweir
changed the title
johnjackweir
changed the title
|
I'll fix the tests but open to any initial feedback on this overall approach of hiding and disallowing additions to the"special" collections |
gribnoysup
reviewed
Sep 17, 2025
| @@ -379,6 +383,14 @@ export const createNamespace = ( | |||
| dispatch(handleError(new Error(NO_DOT))); | |||
There was a problem hiding this comment.
I think I broke this flow ~2 years ago and we never noticed. This should return, otherwise we are continuing to create the namespace even if validation failed.
Suggested change
| dispatch(handleError(new Error(NO_DOT))); | |
| return dispatch(handleError(new Error(NO_DOT))); |
gribnoysup
reviewed
Sep 17, 2025
Comment on lines
386
to
392
| if (dbName && toNS(dbName).special) { | ||
| dispatch(handleError(new Error(INTERNAL_DATABASE))); | ||
| } | ||
|
|
||
| if (toNS(namespace).special) { | ||
| dispatch(handleError(new Error(INTERNAL_COLLECTION))); | ||
| } |
There was a problem hiding this comment.
Same wrt returns
Suggested change
| if (dbName && toNS(dbName).special) { | |
| dispatch(handleError(new Error(INTERNAL_DATABASE))); | |
| } | |
| if (toNS(namespace).special) { | |
| dispatch(handleError(new Error(INTERNAL_COLLECTION))); | |
| } | |
| if (dbName && toNS(dbName).special) { | |
| return dispatch(handleError(new Error(INTERNAL_DATABASE))); | |
| } | |
| if (toNS(namespace).special) { | |
| return dispatch(handleError(new Error(INTERNAL_COLLECTION))); | |
| } |
gribnoysup
reviewed
Sep 17, 2025
Comment on lines
+267
to
+269
| .filter((db) => { | ||
| return toNs(db.name).special === false; | ||
| }) |
There was a problem hiding this comment.
From the top of my head I think that should be an okay change, but I don't know enough about these special collections to say with confidence that we are not breaking some power user use-cases in Compass. Would it make sense to gate this with some new preference setting and allow people to opt-in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WRITING-33247 defines a new pattern of MongoDB owned internal DBs prefixed with
__mdb_internal_Here I propose hiding all special dbs as determined by the mongodb-ns package with the reasoning that users should generally not be aware of these internal DBs, nor should they make changes to them
As of right now, this does not stop a user from creating a new collection in these DBs
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes