WIP: table cell right click #7045
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p menu state consistent The refactor is meant to make the Leafygreen integration more straightforward: 1. We stick to item groups and instead have a single wrapper to handle any rendering differences between groups. This allows the wrapper to always have context of all items when rendering which is useful when inserting menu seperators in Leafygreen. Also encourages consistent UI (while allowing per-case customization if needed at wrapper-level). We could introduce itemWrappers instead of itemGroups but having one wrapper handling all seems cleaner to me. 2. More of the responsibility is moved to a parent wrapper component that will house the context menu. This allows us to standardize the right click menu and make better use of Leafygreen's menu component including its click handling (which has been removed from the context menu library). 3. Menu state (i.e. position) is now preserved even closed; this is useful for leafygreen's menu to animate in the same position instead of losing the position all together.
…ompass into gagik/context-menu-compass-ui
…p menu state consistent The refactor is meant to make the Leafygreen integration more straightforward: 1. We stick to item groups and instead have a single wrapper to handle any rendering differences between groups. This allows the wrapper to always have context of all items when rendering which is useful when inserting menu seperators in Leafygreen. Also encourages consistent UI (while allowing per-case customization if needed at wrapper-level). We could introduce itemWrappers instead of itemGroups but having one wrapper handling all seems cleaner to me. 2. More of the responsibility is moved to a parent wrapper component that will house the context menu. This allows us to standardize the right click menu and make better use of Leafygreen's menu component including its click handling (which has been removed from the context menu library). 3. Menu state (i.e. position) is now preserved even closed; this is useful for leafygreen's menu to animate in the same position instead of losing the position all together.
…ompass into gagik/context-menu-compass-ui
* fix test flakes * nullable * wait for container animations
…xt-menu-compass-ui
…ompass into gagik/context-menu-compass-ui
…ercom integration is allowed COMPASS-9371 (#6982) * Add request to the update server to determine if Intercom integration is allowed * Turn toggleEnableFeedbackPanel async and check isIntercomAllowed * Remove premature optimization of memoizing integrations response * Restore fetch mock correctly * Add debug calls * Fix tests * Fix lint * Use a different domain in proxy tests * Incorporated feedback * Cache response from update server
…playing covered queries) CLOUDP-325467 (#7036) * fix disabled state of suggested index button when switching between tabs * maintain covered queries in btwn tabs * working version of the state management * do not render suggested index everytime initial query changes * skipping failing tests * combine coveredqueries data into an obj * fix broken tests * updated the state to hold coveredQueriesArr instead * fix error clearing, remove suggestions from start (need to fix), move query + initialQuery to redux * fixed tests and automatically generate suggestions when applicable * clear error when query is updated * default query = null for create index modal * added return for the createIndexOpened call * remove irrelevant comment * update tests, move logic to reducer for hasQueryChanges
* Only remove windows installer if it exists * Warn if removal fails * Passing SQUIRREL_TEMP to sandbox the install * Use --checkInstall to silence the Update.exe * Add a debug statement with the executable * Pass --silent directly
…pass-app-registry (#7040) * refactor(app-registry): rename hadron-app-registry to compass-app-registry, rename HadronPlugin to CompassPlugin * fixup: @mongodb-js/compass-app-registry, not compass-app-registry
…xt-menu-compass-ui
…xt-menu-compass-ui
This reverts commit 4dafa7b and uses testing-library instead.
…/compass into gagik/table-cell-right-click
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some quite WIP work for table cell right clicking. Some more work is needed to finalize this, just sharing as I am away next week. Feel free to take over, otherwise I'll just continue from there.
The approach worth taking is likely to use AG-Grid's
onCellContextMenuSelected. This would need some changes to the context menu provider to expose less React-tied functions