chore(eslint-config): update eslint to 8

configs/eslint-config-compass/bin/eslint.js

@@ -1,3 +1,9 @@
 #!/usr/bin/env node
 'use strict';
-require('eslint/bin/eslint.js');
+const path = require('path');
+const eslintPkgJson = require('eslint/package.json');
+const eslintBinPath = path.resolve(
+  path.dirname(require.resolve('eslint/package.json')),
+  eslintPkgJson.bin.eslint
+);
+require(eslintBinPath);

configs/eslint-config-compass/index.js

@@ -15,6 +15,18 @@ const extraTsRules = {
     'error',
     { fixMixedExportsWithInlineTypeSpecifier: false },
   ],
+
+  // TODO: turn those back on
+  '@typescript-eslint/prefer-promise-reject-errors': 'off',
+  '@typescript-eslint/no-explicit-any': 'off',
+  '@typescript-eslint/no-base-to-string': 'off',
+  '@typescript-eslint/no-unsafe-declaration-merging': 'off',
+  '@typescript-eslint/unbound-method': 'off',
+  '@typescript-eslint/no-redundant-type-constituents': 'off',
+  '@typescript-eslint/no-duplicate-type-constituents': 'off',
+  '@typescript-eslint/only-throw-error': 'off',
+  '@typescript-eslint/no-unsafe-enum-comparison': 'off',
+  '@typescript-eslint/no-misused-promises': 'off',
 };
 
 const tsRules = {
@@ -50,13 +62,19 @@ const commonTestOverrides = {
     {
       patterns: [
         {
-          group: '@testing-library/*',
+          group: ['@testing-library/*'],
           message: 'Use @mongodb-js/testing-library-compass instead',
           allowTypeImports: false,
         },
       ],
     },
   ],
+  // Due do chai triggering these rules erroneously in a lot of cases
+  'no-unused-expressions': 'off',
+  '@typescript-eslint/no-unused-expressions': 'off',
+
+  // TODO: turn these back on
+  'mocha/consistent-spacing-between-blocks': 'off',
 };
 
 const testJsOverrides = {

configs/eslint-config-compass/package.json

@@ -15,16 +15,15 @@
   ],
   "dependencies": {
     "@babel/core": "^7.21.4",
-    "@babel/eslint-parser": "^7.14.3",
-    "@mongodb-js/eslint-config-devtools": "^0.9.9",
+    "@babel/eslint-parser": "^7.27.0",
+    "@mongodb-js/eslint-config-devtools": "^0.9.10",
     "@mongodb-js/eslint-plugin-compass": "^1.2.6",
-    "@typescript-eslint/eslint-plugin": "^5.59.0",
-    "@typescript-eslint/parser": "^5.59.0",
-    "eslint": "^7.25.0",
-    "eslint-config-prettier": "^8.3.0",
+    "@typescript-eslint/eslint-plugin": "^8.28.0",
+    "@typescript-eslint/parser": "^8.28.0",
+    "eslint": "^8.57.1",
     "eslint-plugin-filename-rules": "^1.2.0",
     "eslint-plugin-jsx-a11y": "^6.4.1",
-    "eslint-plugin-mocha": "^8.0.0",
+    "eslint-plugin-mocha": "^10.5.0",
     "eslint-plugin-react": "^7.24.0",
     "eslint-plugin-react-hooks": "^4.2.0"
   },

configs/eslint-config-compass/plugin.js

@@ -10,28 +10,51 @@ function restrictedProviderImport(servicePkg) {
   };
 }
 
+// node built-ins with meaningful polyfills in web environment
+const allowedNodeJSBuiltinModules = ['stream', 'events', 'crypto'];
+
 module.exports = {
   ...baseConfig,
   rules: {
     ...baseConfig.rules,
     'no-restricted-imports': 'off',
     '@typescript-eslint/no-restricted-imports': [
       'error',
-      restrictedProviderImport('@mongodb-js/compass-logging'),
-      restrictedProviderImport('@mongodb-js/compass-telemetry'),
-      restrictedProviderImport('@mongodb-js/compass-app-stores'),
-      restrictedProviderImport('@mongodb-js/my-queries-storage'),
-      restrictedProviderImport('@mongodb-js/atlas-service'),
-      restrictedProviderImport('compass-preferences-model'),
-      {
-        paths: require('module').builtinModules,
-        message: 'Using Node.js built-in modules in plugins is not allowed.',
-        allowTypeImports: false,
-      },
       {
-        paths: ['electron', '@electron/remote'],
-        message: 'Using electron modules in plugins is not allowed.',
-        allowTypeImports: false,
+        paths: [
+          restrictedProviderImport('@mongodb-js/compass-logging'),
+          restrictedProviderImport('@mongodb-js/compass-telemetry'),
+          restrictedProviderImport('@mongodb-js/compass-app-stores'),
+          restrictedProviderImport('@mongodb-js/my-queries-storage'),
+          restrictedProviderImport('@mongodb-js/atlas-service'),
+          restrictedProviderImport('compass-preferences-model'),
+          ...require('module')
+            .builtinModules.filter((module) => {
+              return (
+                !module.startsWith('_') &&
+                !allowedNodeJSBuiltinModules.includes(module)
+              );
+            })
+            .flatMap((name) => {
+              const config = {
+                message:
+                  'Using Node.js built-in modules in plugins is not allowed.',
+                allowTypeImports: true,
+              };
+
+              return [
+                { name, ...config },
+                { name: `node:${name}`, ...config },
+              ];
+            }),
+          ...['electron', '@electron/remote'].map((name) => {
+            return {
+              name,
+              message: 'Using electron modules in plugins is not allowed.',
+              allowTypeImports: false,
+            };
+          }),
+        ],
       },
     ],
   },

configs/eslint-plugin-compass/package.json

@@ -40,7 +40,7 @@
     "@mongodb-js/mocha-config-compass": "^1.6.6",
     "@mongodb-js/prettier-config-compass": "^1.2.6",
     "depcheck": "^1.4.1",
-    "eslint": "^7.25.0",
+    "eslint": "^8.57.1",
     "mocha": "^10.2.0",
     "nyc": "^15.1.0"
   }

configs/webpack-config-compass/src/index.ts

@@ -301,7 +301,7 @@ export function createElectronRendererConfig(
 export function createWebConfig(args: Partial<ConfigArgs>): WebpackConfig {
   const opts = webpackArgsWithDefaults(args, { target: 'web' });
 
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   const { peerDependencies } = require(path.join(opts.cwd, 'package.json')) as {
     peerDependencies: Record<string, string>;
   };

configs/webpack-config-compass/src/loaders.ts

@@ -7,7 +7,7 @@ import { isServe } from './args';
 import chalk from 'chalk';
 
 function isLatestBrowserslist() {
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   const browserslistVersion = require('browserslist/package.json').version;
   const command = `npm view browserslist version --json`;
   const latestBrowserslistVersion = JSON.parse(
@@ -18,7 +18,7 @@ function isLatestBrowserslist() {
 }
 
 const electronVersion = (() => {
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   const [maj, min] = require('electron/package.json').version.split(
     '.'
   ) as string[];

configs/webpack-config-compass/src/util.ts

@@ -38,7 +38,7 @@ export function entriesToHtml(
           fs.statSync(maybeTemplatePath);
           template = maybeTemplatePath;
           break;
-        } catch (e) {
+        } catch {
           // ignore and use default template, electron renderer entry will need
           // at least some kind of html page provided one way or the other
         }
@@ -62,7 +62,7 @@ export function camelCase(str: string): string {
 }
 
 export function getLibraryNameFromCwd(cwd: string): string {
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   const { name, productName } = require(path.join(cwd, 'package.json')) as {
     name: string;
     productName: string;