fix(compass-components): do not keep fallback content when not needed COMPASS-7417 #5111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcasimir
reviewed
Nov 14, 2023
| @@ -114,12 +114,14 @@ const fallbackContainer = css({ | |||
| bottom: 0, | |||
| left: 0, | |||
| opacity: 0, | |||
| transition: 'opacity .16s ease-out', | |||
| transition: 'opacity display .16s ease-out', | |||
There was a problem hiding this comment.
i almost feel this can just be confusing at this point, should we just drop it?
There was a problem hiding this comment.
unless i'm missing something ..
There was a problem hiding this comment.
this has a nice side-effect that the visibility(coming into view) of fallback content still gets animated nicely.
There was a problem hiding this comment.
actually there very little difference (just checked again), maybe i will just remove it to cut down any confusion here.
himanshusinghs
changed the title
mcasimir
approved these changes
Nov 14, 2023
himanshusinghs
deleted the
COMPASS-7417-do-not-render-fallback-svg-when-not-needed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fallback content kept rendering css keyframes with opacity 0 which ended up consuming a lot of CPU as seen in the Activity monitor. As I understand, we probably wanted to workaround the inability to animate css display property here and although with the change in place, there is a slight difference in the output, it is probably worth getting to normal CPU usage.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes