Change most of the Deserializer to use forward_to_deserialize_any
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have opened another PR for changing how embedded structs are handled |
This also changes my old commit fixing structs with embedded structs to use a different method. (A bool `read_header` instead of putting a struct marker at the front of the array of data. This also fixes the panics on incomplete structs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #27
This also changes my old commit fixing structs with embedded structs to use a different method. A boolread_headerinstead of putting a struct marker at the front of the array of data.This also fixes the panics on incomplete structs, just forwarding to forward_to_deserialize_any.
I could have removed more of the de-serialize but I feel the explicit errors on unsupported types may be helpful.
I have also changed how the Deserializer handles string markers, this is because epee marks byte arrays as strings so if someone sends a bytes array in a field we don't have this will get forwarded to deserialize_any which will then fail if the byte array isn't an actual string.
@thomaseizinger