-
Notifications
You must be signed in to change notification settings - Fork 15
Reference Rework #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Reference Rework #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simple-dftd3 can run multithreaded with OpenMP, but probably needs to be specifically compiled for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
referencemethodFunction/Hamiltonianreferenceapps around a bitreferenceexecution options slightly more flexibleGENERAL
Referencenow have more evaluation options (behaviour ofcomputeunchanged):reference.evaluate(self, geometry: Geometry | AppFuture) -> AppFuture[Geometry]andreference.compute_dataset(self, dataset: Dataset) -> DatasetGeometrywith its data reset. If that does not happen, you have found a bug. Fixes NaN energy written to xyz after failed CP2K evaluation #77 (hopefully).container_uri,mpi_command,mpi_argsandexecutable. These replace the removedlaunch_commandoption. See e.g., the 'local_test.yaml' config.ORCA
Psiflow workflows can now use ORCA to evaluate molecules. A simple example could be
where
orca_inputis any valid ORCA input file (as a string). You do not have to specify%maxcore,%palor*xyz [...] *options; they will be filled in automatically. If you do supply e.g.,%maxcore 2000, that option will not be overwritten.Note that the default output parser will only work for single point calculations (no optimisations, hessians, etc..). If you need this functionality, feel free to open an issue.
Also, we currently do not have an ORCA container yet, so psiflow assumes the
orcaexecutable can be found in your PATH (doeswhich orcawork?).D3
Dispersion corrections using simple-dftd3 became a
Function/Hamiltonian, mostly because the library is easy to control in pure Python (apps), and every ab initio code has its own dispersion implementation anyway. Usage like anyHamiltonian:Simple-dftd3 can use OpenMP threading with
OMP_NUM_THREADS, but that does not seem to work out of the box. We probably need some specific compilation setup.