Open
Conversation
Contributor
Author
|
PR has been merged in i-PI, let us review! |
Contributor
Author
|
So, unfortunately I made a slight oversight in the driver where I forgot to also include the class itself in the |
Collaborator
|
I think there are two things to tackle here:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overhaul of the client side of i-PI where sockets are now replaced by FFDirect, as mentioned in #85 and #88. For this a PR was opened to include a dedicated Psiflow driver in i-PI. I will keep this as a draft until the PR in i-PI is merged, after this also containers can be updated.