fix: handle state change with identical or missing currentWidgetId #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbarber
requested review from
aaddaamm,
chewnoill,
geraldalewis,
havivian,
joealba and
thedelchop
as code owners
The pi exhibited an issue where a current widget could become stuck and never continue to the next widget. It seems to be caused by clicking on the current widget in the tab. Added some logging in case there are other edge cases.
joealba
previously approved these changes
Mar 2, 2020
There is potentially a race condition between prefetch triggering onComplete and the onComplete for updated query from the state change. This functionality could use a refactor/rethink.
cbarber
force-pushed
the
cmb/fix-stuck-current-widget
branch
from
f7ab65f to
0f7704d
Compare
|
Do you know of any javascript log drains that have a free tier for an easier way to look at these messages? |
chewnoill
approved these changes
May 20, 2021
chewnoill
reviewed
May 24, 2021
Comment on lines
+146
to
+147
| nextWidgetId: null, | ||
| prevWidgetId: null, |
There was a problem hiding this comment.
are these all calculated values?
|
I'm going need some time to remember what this is and if its still neccessary |
|
closed in favor of #252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pi exhibited an issue where a current widget could become stuck and
never continue to the next widget. It seems to be caused by clicking on
the current widget in the tab. Added some logging in case there are
other edge cases.