Updated README.md #167
Open
Updated README.md #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include further information about the notification functionality of the Jenkins GIT plugin being leveraged.
ppodgorsek
suggested changes
Aug 31, 2017
| @@ -4,7 +4,7 @@ After making commits to Bitbucket Server (previously known as Stash), notify Jen | |||
|
|
|||
| ## Requirements | |||
|
|
|||
| + **Git Plugin** - Jenkins needs to have the [Git Plugin](https://wiki.jenkins-ci.org/display/JENKINS/Git+Plugin) installed in Jenkins and the Poll SCM option must be enabled | |||
| + **Git Plugin** - Jenkins needs to have the [Git Plugin](https://wiki.jenkins-ci.org/display/JENKINS/Git+Plugin) installed in Jenkins and the Poll SCM option must be enabled. It specifically leverages the [notification capability](https://wiki.jenkins-ci.org/display/JENKINS/Git+Plugin#GitPlugin-Pushnotificationfromrepository) of that plugin which can be triggered without providing any authentication information. | |||
There was a problem hiding this comment.
The extra information is useful but we shouldn't put too many external links/anchors to avoid having to maintain broken links.
Simply keeping the phrase without the link seems a better option: (people can always search for themselves on the Git plugin page)
It specifically leverages the notification capability of that plugin which can be triggered without providing any authentication information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include further information about the notification functionality of the Jenkins GIT plugin being leveraged.