Fix dot stuffing bug #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: http://stackoverflow.com/questions/15224224/smtp-dot-stuffing-when-and-where-to-do-it http://tools.ietf.org/html/rfc5321#section-4.5.2 According to the SMTP standard RFC 5321, section 4.5.2: > To allow all user composed text to be transmitted transparently, the following procedures are used: * Before sending a line of mail text, the SMTP client checks the first character of the line. If it is a period, one additional period is inserted at the beginning of the line. * When a line of mail text is received by the SMTP server, it checks the line. If the line is composed of a single period, it is treated as the end of mail indicator. If the first character is a period and there are other characters on the line, the first character is deleted. The current version of sendemail does not pad lines beginning with a period with another period, mails sent via sendemail are received with that first period truncated. This bug is fixed by doing a regexp search for all lines in $message beginning with a "." and replace with ".."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
http://stackoverflow.com/questions/15224224/smtp-dot-stuffing-when-and-where-to-do-it
http://tools.ietf.org/html/rfc5321#section-4.5.2
According to the SMTP standard RFC 5321, section 4.5.2:
The current version of sendemail DOES pad lines consisting ONLY of a single period (
.), but DOES NOT pad lines that begin with a period with another period. The result of this behavior is that mails sent via sendemail are received with that first period truncated.For example, if you send an e-mail with the body text:
You will receive that e-mail with the following body text:
This bug is fixed by doing a regexp search for all lines in
$messagebeginning with a.and replace with...