fix(gateway): propagate generation params to inference request#1342
Open
Bhanudahiyaa wants to merge 1 commit intomofa-org:mainfrom
Open
fix(gateway): propagate generation params to inference request#1342Bhanudahiyaa wants to merge 1 commit intomofa-org:mainfrom
Bhanudahiyaa wants to merge 1 commit intomofa-org:mainfrom
Conversation
Contributor
Author
|
This change closes a contract gap between the OpenAI compatible API layer and internal inference orchestration. Previously, request-level generation controls ( Question for maintainersShould we follow up with explicit validation ranges at the gateway boundary (e.g., temperature bounds), or leave normalization/validation to downstream provider adapters? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures OpenAI-compatible generation controls (max_tokens, temperature) are carried through gateway translation into internal InferenceRequest instead of being silently
discarded.
Motivation
The API contract already exposes these parameters, but runtime translation dropped them. That mismatch causes surprising behavior and makes the gateway less trustworthy for
OpenAI-compatible clients.
Fixes: #1341
What changed
Files changed
Design notes / tradeoffs
Tests added/updated
Validation run
Checklist
———