fix(recovery): recover from poisoned mutex in CircuitBreaker#1338
Open
ashnaaseth2325-oss wants to merge 1 commit intomofa-org:mainfrom
Open
fix(recovery): recover from poisoned mutex in CircuitBreaker#1338ashnaaseth2325-oss wants to merge 1 commit intomofa-org:mainfrom
ashnaaseth2325-oss wants to merge 1 commit intomofa-org:mainfrom
Conversation
Replace .lock().unwrap() with .lock().unwrap_or_else(|e| e.into_inner()) in all five CircuitBreaker methods so a thread panic while holding the lock does not cascade into panics on every subsequent caller. Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
Contributor
Author
|
Hello @LuigiGonnella @mugiwaraluffy56 , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR prevents runtime panics in the
CircuitBreakerby safely handling poisoned mutex locks instead of unwrapping them. It updates lock acquisition logic acrosscrates/mofa-foundation/src/recovery.rs, ensuring the circuit breaker continues functioning even after a thread panic.FIX
Root cause:
std::sync::Mutex::lock().unwrap()panics when the mutex is poisoned, causing cascading failures in all subsequent calls.Technical approach:
Replace
.unwrap()with.unwrap_or_else(|e| e.into_inner())to recover the guard from a poisoned mutex and continue execution safely.Before (problematic pattern):
After (safe handling):
Applied consistently across:
state()call()record_success()record_failure()reset()VERIFICATION
CircuitBreakerinstance.record_failure()).state()orcall().