fix(foundation): propagate workflow DSL retry config to runtime nodes#1312
Open
Bhanudahiyaa wants to merge 1 commit intomofa-org:mainfrom
Open
fix(foundation): propagate workflow DSL retry config to runtime nodes#1312Bhanudahiyaa wants to merge 1 commit intomofa-org:mainfrom
Bhanudahiyaa wants to merge 1 commit intomofa-org:mainfrom
Conversation
Contributor
Author
|
Would appreciate a quick look when you get a chance, especially around whether the retry propagation approach aligns with the intended workflow execution model. Happy to adjust based on feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Propagates workflow DSL execution config into runtime node configuration so retry and timeout settings defined in YAML/JSON are applied during parser/build.
Motivation
Workflow Engine DSL exposes config fields (retry/timeout), but parser/build behavior was partial. This prevented reliable end-to-end execution semantics from DSL definitions.
Changes
crates/mofa-foundation/src/workflow/dsl/parser.rsto:retry_policy,default_timeout_ms) to all runtime nodes.retry_policy,timeout_ms, metadata).workflow_retry_and_timeout_defaults_propagatenode_retry_and_timeout_override_workflow_defaultsRelated Issues
Resolves #1311
Testing
cargo test -p mofa-foundation workflow::dsl::parser::tests -- --nocaptureChecklist
cargo fmt --checkpassescargo clippy --workspace --all-features -- -D errorspassescargo test --workspace --all-featurespassescargo build --examplessucceedscargo doc --workspace --no-deps --all-featuressucceeds