chore(workspace): enforce clippy warnings and format workspace#1302
Open
Bhanudahiyaa wants to merge 1 commit intomofa-org:mainfrom
Open
chore(workspace): enforce clippy warnings and format workspace#1302Bhanudahiyaa wants to merge 1 commit intomofa-org:mainfrom
Bhanudahiyaa wants to merge 1 commit intomofa-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforces warning-level clippy gating and aligns workspace formatting/lint baseline so local and CI quality gates behave as intended.
Motivation
The previous clippy command used
-D errors, which does not correctly deny warnings. This weakens lint enforcement and can hide actionable diagnostics. Additionally, workspace formatting drift causedcargo fmt --checkfailures.Changes
-D errorsto-D warningsin:.github/workflows/ci.ymlCONTRIBUTING.md(all listed quality-gate/checklist command references)crates/mofa-foundation/src/llm/google.rs(collapsed nestedifstatements).cargo fmt --checkto pass across the workspace.Related Issues
Resolves #1301
Testing
cargo fmt --check cargo clippy --workspace --all-features -- -D warnings PYO3_PYTHON=/opt/homebrew/bin/python3.11 cargo test --workspace --all-features cargo build --examples cargo doc --workspace --no-deps --all-featuresChecklist
cargo fmt --checkpassescargo clippy --workspace --all-features -- -D warningspassescargo test --workspace --all-featurespassescargo build --examplessucceedscargo doc --workspace --no-deps --all-featuressucceedsCONTRIBUTING.md)